Giter Site home page Giter Site logo

Comments (10)

frederikhors avatar frederikhors commented on May 9, 2024 6

After several tests, I finally understood what is happening.

If in my package.json I use the new CRA 3 default below:

"browserslist": {
  "production": [
    ">0.2%",
    "not dead",
    "not op_mini all"
  ],
  "development": [
    "last 1 chrome version",
    "last 1 firefox version",
    "last 1 safari version"
  ]
}

deleting before npm start the node_modules/.cache folder it doesn't work!

Re-deleting .cache folder with your below browserlist in package.json it works!

  "browserslist": [
    ">0.2%",
    "not dead",
    "not ie <= 11",
    "not op_mini all"
  ]

did you try "@welldone-software/why-did-you-render" before?

yes of course

from why-did-you-render.

ljosberinn avatar ljosberinn commented on May 9, 2024

From what I can tell, this is not related to why-did-you-render at all but a regular javascript TypeError.

from why-did-you-render.

frederikhors avatar frederikhors commented on May 9, 2024

Everything else works good.

from why-did-you-render.

vzaidman avatar vzaidman commented on May 9, 2024

did you try "@welldone-software/why-did-you-render" before?

from why-did-you-render.

vzaidman avatar vzaidman commented on May 9, 2024

what is Navbar?

from why-did-you-render.

vzaidman avatar vzaidman commented on May 9, 2024

create-react-app 3 and wdyr works together:
https://codesandbox.io/s/8ylmw38rl

from why-did-you-render.

frederikhors avatar frederikhors commented on May 9, 2024

@vzaidman, why did you close? There is still a problem.

from why-did-you-render.

vzaidman avatar vzaidman commented on May 9, 2024

oh i thought you said "it works"

from why-did-you-render.

vzaidman avatar vzaidman commented on May 9, 2024

whats your current browser list? how do you import wdyr? what component are you using it on?

from why-did-you-render.

vzaidman avatar vzaidman commented on May 9, 2024

@frederikhors as far as i know it should work. we have tests that verify these scenarios. there are, however, some serious issues with browserlist cache that are not related to the project.

please do the following:

  • change broserlist and babel config according to your need
  • delete node_modules/.cache
  • re-run

if the issue remains, you are free to reopen this issue and specify:

  • your current .browserlistrc
  • your babel config
  • how do you import wdyr
  • how do you use it and on what component

from why-did-you-render.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.