Giter Site home page Giter Site logo

Comments (2)

welpo avatar welpo commented on May 29, 2024 2

Implemented both suggestions (dark/light scrollbars & unhiding them) on commits above.

Like you, I opted not to modify the logic of the JS theme switcher to have the scrollbars instantly react to the theme changes (https://stackoverflow.com/a/66097469); it feels kind of dirty forcing a reflow and adding JS complexity (and bytes) for this minor benefit.

from tabi.

welpo avatar welpo commented on May 29, 2024

Hey Jake!

Thanks for your kind comments. You already know Abridge has been a source of inspiration for this theme as well. I'm glad we can both help each other :)

You're right about the horizontal scrolling not being too obvious. It should be possible with Shift + Scroll, though. It's standard OS behaviour in Windows and macOS, but not many know about this.

I hid the scrollbars because I don't like them for codeblocks, but I think this is something that should follow user preference, so I'll add them back (and hide them for myself through the OS settings).

Regarding the button to expand codeblocks, I think it'll be hard without JavaScript, unless you use a shortcode to build the codeblock. That way you can create a switcher for it and change its display through CSS when activated (I use this toggle function for the multilingual quote, image toggler and the spoiler shortcodes).

Thanks for sharing the Chrome styling info! I will definitely look into it!

from tabi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.