Giter Site home page Giter Site logo

Comments (3)

welpo avatar welpo commented on May 29, 2024 1

Very cool! I was not aware of this element.

Not sure if anything changed but last time I did this CSS variables weren't supported.

Indeed, I just tested it and CSS variables aren't supported.

It would be possible to use JavaScript to update the value, but I'd rather not add JS for such a minor feature.

In fact, even then, that would not be very helpful with the default values. If your colour si too bright, (at least) Safari will ignore the value when the OS is set to dark. And Safari considers the primary-color too bright on dark mode (not just for the default teal theme, but for all the skins I tested too).

from tabi.

welpo avatar welpo commented on May 29, 2024 1

Done! You can set a single value or an array like:

browser_theme_color = ["#ffffff", "#000000"]  # [light, dark]
browser_theme_color = "#ffffff"

See the PR #143 for a screenshot.

Thanks for this suggestion!

from tabi.

donovanglover avatar donovanglover commented on May 29, 2024

Not sure if anything changed but last time I did this CSS variables weren't supported. Might need to use a config value instead.

from tabi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.