Giter Site home page Giter Site logo

Comments (16)

TheAwiteb avatar TheAwiteb commented on June 21, 2024 2

Does this solve the issue?

I'll soon in the morning, now it's 1:06 AM and I close the laptop :)

from tabi.

welpo avatar welpo commented on June 21, 2024 1

Screenshot

Is this the problem? (Using your two images from the first post)

from tabi.

TheAwiteb avatar TheAwiteb commented on June 21, 2024 1

Screenshot

Is this the problem? (Using your two images from the first post)

Yes, also the second and last tag.

Tag Become Reason (in Arabic)
شرح شرحـ Because it's stick with the second tag
شي ـشيـ Because it's stick with the first and last tag
ما ـما Because it's stick with the second tag

from tabi.

TheAwiteb avatar TheAwiteb commented on June 21, 2024 1

Does this solve the issue?

Yes it's, I'll open a PR

from tabi.

TheAwiteb avatar TheAwiteb commented on June 21, 2024

If adding a space is a suitable solution, then I will create a PR for it, or you can suggest another solution

from tabi.

welpo avatar welpo commented on June 21, 2024

Thanks for reporting this bug!

Is this still an issue if you set the language to Arabic after #262?

Also: in both images (expected vs current behavior) I see good spacing between the tags. I'm not sure I understand the bug. From your description, I expected to see a bunch of grouped tags like "شرحشيما".

from tabi.

TheAwiteb avatar TheAwiteb commented on June 21, 2024

Is this still an issue if you set the language to Arabic after #262?

Yes, I actually test it in it's branch, but didn't mention it because it's was not released yet

I'm not sure I understand the bug. From your description, I expected to see a bunch of grouped tags like "شرحشيما".

No, there is 3 tags which is "شرح", "شي and "ما", and it's should looks as separated tags of course, but now it's look like one word "شرحشيما" with spaces between the actual words, some like "شرحـ ـشيـ ـما"

from tabi.

welpo avatar welpo commented on June 21, 2024

now it's look like one word "شرحشيما" with spaces between the actual words, some like "شرحـ ـشيـ ـما"

So there is space, but not enough of it?

from tabi.

TheAwiteb avatar TheAwiteb commented on June 21, 2024

now it's look like one word "شرحشيما" with spaces between the actual words, some like "شرحـ ـشيـ ـما"

So there is space, but not enough of it?

I'm not a frontend developer so I can't point for the issue exactly, but what I know there is space between tags, but there is no space between the words, so because that it's comes like one word. It doesn't really make sense, but yeah this is Arabic

from tabi.

welpo avatar welpo commented on June 21, 2024

Don't worry, I'm just trying to understand the issue.

So:

  • Spaces between tags are OK ✅
  • From this, I take that single-word tags look okay ✅
  • If a single tag has spaces (like "multi word tag"), the issue appears ⚠️

Am I understanding it right?

from tabi.

TheAwiteb avatar TheAwiteb commented on June 21, 2024

the issue appears

No, the tags of the example above is

[taxonomies]
tags = ["شرح", "شي", "ما"]

from tabi.

welpo avatar welpo commented on June 21, 2024

If I add the spaces like this:

<div class="bloglist-tags">
    <a class="tag" href="http://127.0.0.1:1111/tags/shrh/"> شرح</a>
    <a class="tag" href="http://127.0.0.1:1111/tags/shy/"> شي</a>
    <a class="tag" href="http://127.0.0.1:1111/tags/m/"> ما</a>
</div>

It looks like:

space_added

If I don't change anything (current behaviour), the tags look like:

current


To my non-Arabic-reading eyes, this looks like a minor difference? Is the top image the ideal, and the bottom the problem?

from tabi.

TheAwiteb avatar TheAwiteb commented on June 21, 2024

If I don't change anything (current behaviour), the tags look like:

current

Is not same as my output above!! This looks good

from tabi.

welpo avatar welpo commented on June 21, 2024

I can reproduce the issue on Chromium. It looks fine on Firefox/Safari.

Are you using a Chromium browser (Chrome, Brave, Vivaldi…)?

from tabi.

TheAwiteb avatar TheAwiteb commented on June 21, 2024

Are you using a Chromium browser (Chrome, Brave, Vivaldi…)?

Yes Brave

from tabi.

welpo avatar welpo commented on June 21, 2024

Can you try this?
On sass/parts/_posts_list.scss add display: inline-block; for the tags:

    .bloglist-tags {
        margin-top: 0.1rem;

        .tag {
            display: inline-block;
            margin-right: 0.7rem;
            font-weight: 400;
            font-size: 0.75rem;
            text-transform: uppercase;
        }

Does this solve the issue?

from tabi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.