Comments (16)
Does this solve the issue?
I'll soon in the morning, now it's 1:06 AM and I close the laptop :)
from tabi.
Is this the problem? (Using your two images from the first post)
from tabi.
Is this the problem? (Using your two images from the first post)
Yes, also the second and last tag.
Tag | Become | Reason (in Arabic) |
---|---|---|
شرح | شرحـ | Because it's stick with the second tag |
شي | ـشيـ | Because it's stick with the first and last tag |
ما | ـما | Because it's stick with the second tag |
from tabi.
Does this solve the issue?
Yes it's, I'll open a PR
from tabi.
If adding a space is a suitable solution, then I will create a PR for it, or you can suggest another solution
from tabi.
Thanks for reporting this bug!
Is this still an issue if you set the language to Arabic after #262?
Also: in both images (expected vs current behavior) I see good spacing between the tags. I'm not sure I understand the bug. From your description, I expected to see a bunch of grouped tags like "شرحشيما".
from tabi.
Is this still an issue if you set the language to Arabic after #262?
Yes, I actually test it in it's branch, but didn't mention it because it's was not released yet
I'm not sure I understand the bug. From your description, I expected to see a bunch of grouped tags like "شرحشيما".
No, there is 3 tags which is "شرح", "شي and "ما", and it's should looks as separated tags of course, but now it's look like one word "شرحشيما" with spaces between the actual words, some like "شرحـ ـشيـ ـما"
from tabi.
now it's look like one word "شرحشيما" with spaces between the actual words, some like "شرحـ ـشيـ ـما"
So there is space, but not enough of it?
from tabi.
now it's look like one word "شرحشيما" with spaces between the actual words, some like "شرحـ ـشيـ ـما"
So there is space, but not enough of it?
I'm not a frontend developer so I can't point for the issue exactly, but what I know there is space between tags, but there is no space between the words, so because that it's comes like one word. It doesn't really make sense, but yeah this is Arabic
from tabi.
Don't worry, I'm just trying to understand the issue.
So:
- Spaces between tags are OK ✅
- From this, I take that single-word tags look okay ✅
- If a single tag has spaces (like "multi word tag"), the issue appears
⚠️
Am I understanding it right?
from tabi.
the issue appears
No, the tags of the example above is
[taxonomies]
tags = ["شرح", "شي", "ما"]
from tabi.
If I add the spaces like this:
<div class="bloglist-tags">
<a class="tag" href="http://127.0.0.1:1111/tags/shrh/"> شرح</a>
<a class="tag" href="http://127.0.0.1:1111/tags/shy/"> شي</a>
<a class="tag" href="http://127.0.0.1:1111/tags/m/"> ما</a>
</div>
It looks like:
If I don't change anything (current behaviour), the tags look like:
To my non-Arabic-reading eyes, this looks like a minor difference? Is the top image the ideal, and the bottom the problem?
from tabi.
If I don't change anything (current behaviour), the tags look like:
Is not same as my output above!! This looks good
from tabi.
I can reproduce the issue on Chromium. It looks fine on Firefox/Safari.
Are you using a Chromium browser (Chrome, Brave, Vivaldi…)?
from tabi.
Are you using a Chromium browser (Chrome, Brave, Vivaldi…)?
Yes Brave
from tabi.
Can you try this?
On sass/parts/_posts_list.scss
add display: inline-block;
for the tags:
.bloglist-tags {
margin-top: 0.1rem;
.tag {
display: inline-block;
margin-right: 0.7rem;
font-weight: 400;
font-size: 0.75rem;
text-transform: uppercase;
}
Does this solve the issue?
from tabi.
Related Issues (20)
- Blog and Projects on homepage HOT 7
- "All posts ->" in main page links to "blog/" is hardcoded, so dead link if other section was chosen for main page HOT 3
- Wrong history url for gitlab and codeberge
- Change Language icon not showing HOT 11
- Umami analytics blocked unless CSP is modified HOT 1
- Misaligned posts when showing latest projects HOT 3
- Projects in RSS Feed HOT 4
- Too little spacing between projects (at the top) and posts HOT 2
- Allow fetching code blocks from external source, display reference in code block title HOT 14
- Umami analytics broken by CSP
- Project on archive page HOT 2
- E-mail icon dissapears when all social icons are off HOT 1
- Add OSM map (Leaflet) to Tabi HOT 4
- Add inline image in text HOT 6
- Turn off (disable or hide) "blog" section on the main page HOT 10
- nani_logo.webp cannot be read HOT 2
- author in page.html HOT 5
- non-css syntax highlighting doesn't work (and is fixed to one theme) HOT 7
- <h2> renders (almost?) the same size as <h1> HOT 3
- Possible performance issues HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tabi.