bug: type inference won't work when `constructor` has no `stateMutability` property

[chenxsan]

bug: type inference won't work when `constructor` has no `stateMutability` property

[Raiden1411]

I have an idea that could make this work. I am testing it out and if it works I wil create a discussion on viem since I think the topic that we are discussing is more appropriate there since here we dont control those functions types here.

[Raiden1411]

This means if you don't define a state mutability (view, pure, payable) in your function or constructor, then the stateMutability will be inferred as nonpayable meaning that the stateMutability will always be present on the abi.
I don't think I've seen an compiled abi without the stateMutability property on it, either as a function or constructor.

Your suggested fix does work. So I will let @tmm share his thoughts on the matter.

[tmm]

Agree with @Raiden1411's comment. @chenxsan Where did you get the ABI from? (block explorer, compiler output, etc.)

Going to close this out as expected behavior. Can discuss further once we know where the ABI came from.

[chenxsan]

Agree with @Raiden1411's comment. @chenxsan Where did you get the ABI from? (block explorer, compiler output, etc.)

Going to close this out as expected behavior. Can discuss further once we know where the ABI came from.

Interesting, I get it from a canto explorer, see https://tuber.build/address/0x990efF367C6c4aece43c1E98099061c897730F27/contracts#address-tabs, that's when I found type inference won't work in my case.

Btw, let's say stateMutability is required for constructor, then is it possible to report error about the type of inline abi? Obviously { type: 'constructor', inputs: [ { type: 'address', name: 'token_addr' }, { type: 'address', name: 'art_proxy' }, ], } isn't valid per AbiConstructor, it would be great typescript can report it. Otherwise we have to dig the problem ourselves.

[Raiden1411]

@chenxsan If you take the source code from that link and compile it in remix, you will see that the stateMutability gets placed on the constructor's abi. You can also use the IsAbi type helper to check if the abi that you are using is within the abi spec.
Using your example, you will see that when using the type helper, it results in false.

@tmm could possibly make sense in bubbling up the error so that folks get the error message as the (function|event|error) name autocomplete suggestion, given that there are no throw types. Let me know what you think.

[tmm]

Yeah, down if there's an easy way to bubble it up! Think it might be challenging the way things are currently set up since we fall back if it's not an ABI with readonly unknown[].

[Raiden1411]

Discussion created here.