Option to link against system libraries of freetype, libpng and zlib

[lilydjwg]

Option to link against system libraries of freetype, libpng and zlib

[wez]

You mentioned rustup above: whether you use rustup or not shouldn't have any bearing on how freetype is linked in. You need to have a reasonably recent version of rust + cargo installed to build wezterm.

freetype and harfbuzz are co-dependent libraries and most distributions do not have the right combination of these available and built with the correct build options, which is why we bundle and build them. These libraries do not get updated very frequently by distributions (which is another reason for bundling) and weakens the argument that you will receive updates from your distribution.

I spent a lot of time getting the build in its current reproducible state so, while I have empathy for the slow downloads you're experiencing, I'm sorry to say that I don't think the amount of effort required to get the build working that way is worth the time.

If you, or someone else, wanted to submit a PR that makes this possible I'm open to it, but I would want it to not be the default mode of operation.

As an alternative proposal, consider making a PR for the azure pipelines configuration that captures the built artifacts using the same mechanism we use for the other targets; then we would have a binary tarball or package download for Arch. This feels like a more impactful use of time!

[wez]

Thanks for the pull requests! I'm currently traveling so it may take a few days before I can fully review these!

[wez]

I decided against allowing this; see #48 (comment) for the rationale

[Logarithmus]

@wez why don't you use https://lib.rs/crates/harfbuzz_rs & https://lib.rs/crates/freetype?
Do they lack any features you need for wezterm?

[wez]

When I started this, they didn't exist and/or the only existing bindings linked only against system libraries, but I require static linkage of known versions so that I have consistent behavior across windows, mac and linux. In particular, freetype, harfbuzz, zlib and png are problematic on windows; all are required for proper color emoji support.

If those other crates now meet those requirements then I'm open to a PR that targets them.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.