Doesn't lowercase small words

[q3cpma]

Doesn't lowercase small words

[wezm]

Well that's embarrassing, thanks for the bug report. Can't believe I don't have a test case for that, despite the behaviour being mentioned in the README. The code looks like it's trying to do it:

titlecase/src/lib.rs

Lines 115 to 116 in 9366767

	} else if SMALL_RE.is_match(word) {
	word.to_lowercase()

But I suspect the \A and \z in SMALL_RE are not right.

titlecase/src/lib.rs

Line 81 in 9366767

static ref SMALL_RE: Regex = Regex::new(&format!(r"\A(?:{})\z", SMALL_WORDS.join("|")))

[q3cpma]

On Tue Aug 30, 2022 at 1:20 AM CEST, Wesley Moore wrote: Well that's embarrassing, thanks for the bug report. Can't believe I don't have a test case for that, despite the behaviour being mentioned in the README. The code looks like it's trying to do it: https://github.com/wezm/titlecase/blob/93667678ed18f2b8b4762cfa838070bb014d391c/src/lib.rs#L115-L116 But I suspect the `\A` and `\z` in `SMALL_RE` are not right.

Having tried to do it by myself, I suspect you need lookbehind/lookahead constraints if you want to do it with regexp, which Rust don't have. So, a manual scanner may be needed.

[wezm]

Published v2.1.0 with a fix for this.

[q3cpma]

On Tue Aug 30, 2022 at 2:22 PM CEST, Wesley Moore wrote: Published v2.1.0 with a fix for this.

Thanks.