BaseClass question

[ThorvaldAagaard]

BaseClass question

[wf9a5m75]

How about .then() instead of .subscribe()?

[ThorvaldAagaard]

Not allowed for Observable. But changing the type to Promise will allow that function and is probably the fix

[wf9a5m75]

Morning

[wf9a5m75]

I finally came back to this project. I'm trying to catch up this issue, just a moment please.

[wf9a5m75]

I checked the @ionic-native/src/plugins/google-maps/index.ts

• then is for one time event.

     map.addMarker({...}).then(() => {});

• subscribe is for the event more than one time (it means addEventListener)

     map.on(GoogleMapsEvent.CAMERA_CHANGE).subscribe(()=>{});

BaseArrayClass fires insert_at, set_at and remove_at events more than one time,
the code should use subscribe.

let baseArrayClass = new BaseArrayClass();
baseArrayClass.on('insert_at').subscribe(() => {

});

[ThorvaldAagaard]

Marker is working fine and as expected

      var markers = new BaseArrayClass([]);
      markers.on('insert_at').subscribe(() => {
      });

note that BaseArrayClass does not have a default constructor in the Ionic wrapper

The problem is this one

    self.geocoder.geocode({
      // US Capital cities
      "address": [
        "Montgomery, AL, USA", "Juneau, AK, USA", "Phoenix, AZ, USA",
....
        "Providence, RI, USA", "Columbia, SC, USA", "Pierre, SD, USA",
        "Nashville, TN, USA", "Austin, TX, USA", "Salt Lake City, UT, USA",
        "Montpelier, VT, USA", "Richmond, VA, USA", "Olympia, WA, USA",
        "Charleston, WV, USA", "Madison, WI, USA", "Cheyenne, Wyoming, USA"
      ]
    }).then((mvcArray: BaseArrayClass<GeocoderResult>) => {
     // Init some other stuff
      mvcArray.on('insert_at').subscribe((index) => {

      });

When the statement is executed I get the error

Cannot read property 'subscribe' of undefined

I added a breakpoint in BaseClass.js

    self.on = function(eventName, callback) {
      if (!eventName || !callback || typeof callback !== "function") {
        return;
      }

and on this call callback is undefined

Looking at javascript console it looks like this

Pressing F11 (single step) results in this:

[wf9a5m75]

note that BaseArrayClass does not have a default constructor in the Ionic wrapper

It seems BaseArrayClass of the ionic wrapper has default constructor.
https://github.com/wf9a5m75/ionic-native/blob/57179a125b66afbcb5ea0c5f6aa27be6d1423a6c/src/%40ionic-native/plugins/google-maps/index.ts#L557-L565

[wf9a5m75]

I found the reason.

The BaseArrayClass of ionic wrapper extends IonicNativePlugin

export class BaseArrayClass<T> extends IonicNativePlugin {

But the original BaseArrayClass extends BaseClass

utils.extend(BaseArrayClass, BaseClass);

That's the reason.

[wf9a5m75]

Hence, the BaseArrayClass should be like this:

export class BaseArrayClass<T> extends BaseClass {

[ThorvaldAagaard]

Ok, I will update that

[wf9a5m75]

Thank you :)

[ThorvaldAagaard]

I have changed that but still have the same problem with the subscribe.

But I did look in Geocode.js where the mvcArray is created

    if (geocoderRequest[requestProperty] instanceof Array || 
    Array.isArray(geocoderRequest[requestProperty])) {
        //-------------------------
        // Geocoder.geocode({
        //   address: [
        //    "Kyoto, Japan",
        //    "Tokyo, Japan"
        //   ]
        // })
        //-------------------------
        requestCnt = geocoderRequest[requestProperty].length;
        mvcResults = common.createMvcArray();
        for (i = 0; i < requestCnt; i++) {
          mvcResults.push(-1, true);
        }

the createMvcArray() looks like this

function createMvcArray(array) {
    var mvcArray;
    if (array && typeof array.getArray === "function") {
        mvcArray = new BaseArrayClass(array.getArray());
        array.on('set_at', function(index) {
            var value = array.getAt(index);
            value = "position" in value ? value.getPosition() : value;
            mvcArray.setAt(index, value);
        });
        array.on('insert_at', function(index) {
            var value = array.getAt(index);
            value = "position" in value ? value.getPosition() : value;
            mvcArray.insertAt(index, value);
        });
        array.on('remove_at', function(index) {
            mvcArray.removeAt(index);
        });

    } else {
        mvcArray = new BaseArrayClass(!!array ? array.slice(0) : undefined);
    }
    return mvcArray;

So the BaseArrayClass is instantiated with an undefined type, could that be the issue - And I am just guessing, haven't still figured all the aspects of the mapping out :-)

[wf9a5m75]

Um, I will catch up you. Just a moment please.

[wf9a5m75]

@ThorvaldAagaard I fixed the BaseArrayClass definition. Please git pull, npm run build google-maps, then reinstall npm uninstall @ionic-native/google-maps; npm install (path to)/ionic-native/dist/\@ionic-native/google-maps

https://github.com/wf9a5m75/ionic-native/commit/2c7e686d121f5b6054ed597051c2aba86aaf3ab4

[ThorvaldAagaard]

Great, I will test the change, it almost the same as the one I made, but I can see you are instantiating the property a different way then I did

this._objectInstance = GoogleMaps.getPlugin().BaseArrayClass(initialData); 

I will get back with the result in a moment

[ThorvaldAagaard]

Hmm,

mvcArray.on('insert_at').subscribe((index) => {
});

still executes the on() method on BaseClass directly with an undefined callback

but

  var markers = new BaseArrayClass([]);
  markers.on('insert_at').subscribe(() => {
  });

executes this method

Both are of type BaseArrayClass

but it is like the working one has an outer level

_objectInstance

This is only executed for the working one

function BaseArrayClass(initialData) {
    var _this = _super.call(this) || this;
    _this._objectInstance = GoogleMaps.getPlugin().BaseArrayClass(initialData);
    return _this;
}

whereas the mvcArray is instantiated directly.

I can see in Common.js the reference to BaseArrayClass is the one in BaseArrayClass.js and not the definition in the Ionic-wrapper.

But I have no idea about how to fix that

[wf9a5m75]

Sorry, I finally came back. I will check this deeply from now.

[ThorvaldAagaard]

No problem. I am learning, but its bedtime here now

[wf9a5m75]

Yap. Please have a good sleep. I'm also still learning. I will update.

[wf9a5m75]

@ThorvaldAagaard I fixed the bug of BaseArrayClass and Geocoder.geocode.
And I also created the page of Geocoder/geocoding.

Please git pull both @ionic-native repository and this repository.

[ThorvaldAagaard]

Working fine, thus there seems to be a minor error but I will close this and create a new issue