Comments (8)
jgrund
commented on July 20, 2024
Should the store contain a stream or can we pass state directly into the component?
from gui.
jgrund
commented on July 20, 2024
Also should account for z-indexing somehow.
from gui.
johnsonw
commented on July 20, 2024
Regarding the indexing, I wonder if it's needed. Let's say I have this:
<body>
<ConfirmActionModal />
<CommandModal />
<StepsModal />
</body>
I think the order is important here. While it's possible to have more than one modal open, would we ever have the command modal on top of the steps modal? If I remember correctly, the steps would always display on top of the command. I may not be accounting for a different modal though in which case my logic would be flawed. What do you think?
from gui.
jgrund
commented on July 20, 2024
yeah, I think that makes sense.
from gui.
johnsonw
commented on July 20, 2024
Short demo demonstrating the following:
- Action dropdown
- Command modal
- Step modal
- New Add Server modal
from gui.
jgrund
commented on July 20, 2024
Nice changes.
A few comments:
- When we start to debounce, can we move the spinner inside the search box (right hand side).
- Wait for results to come back before showing the cluster status header and inner component.
- When we have grey boxes, do we need to show the popover when they are clicked? They will have to be green since that's they only way they were added.
- Perhaps do a well for the cluster status section and add more top + bottom padding to differentiate it from the rest of the modal.
- Instead of having separate modals for each step in the add server process, use a single modal and switch its inner state being rendered depending on the event send through the store.
- You are going to want an interstitial when moving between steps to indicate the process moving forward.
- If an accordion element is open, we should have the toggle chevron facing downward.
- Icons next to job links need a bit of right margin + colors applied.
- Did we use to have a way to skip the command modal appearing (a toggle item in the proceed button).
- Wait for the profile statuses to be resolved before displaying the server_profile step.
from gui.
johnsonw
commented on July 20, 2024
Regarding item 3, a host could be registered but it might be offline, which would show that certain items are not valid. That being said, I don't think it buys us much, so I will just remove the popover on the gray boxes.
from gui.
jgrund
commented on July 20, 2024
Closing. command modal is an inferno component.
from gui.
Related Issues (20)
- Create reducer for locks
- Interface with lock reducer to in action-dropdown and job indicator HOT 1
- Handle EventSource disconnects
- Convert disconnect modal to inferno component
- Integrate Wasm ActionDropdown component into GUI
- "An unexpected error" throwed in case of button "next" pushed and more than 50 disks available on server HOT 1
- No error notification in sidebar for Target
- Disable Power Control until Managed Servers are Added
- Job indicator throwing exception
- Command modal not showing all jobs or links HOT 9
- Cannot stop filesystem HOT 1
- scrolling not working on step modal HOT 2
- Fs screen shows HSM info HOT 1
- UI doesn't load when deploying in Docker from latest images HOT 14
- UI doesn't show volumes HOT 13
- Target IDs shown on charts instead of names HOT 4
- Large delay between clicking action and displaying command modal
- How to start the service with one docker run command?
- Selecting filesystem from dashboard dropdown causes an error
- wasm_bindgen updates
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gui.