how can I return an ArrayBuffer in the body?

[wheresrhys]

how can I return an ArrayBuffer in the body?

[wheresrhys]

I'll write a failing test and then look at this. It's not a feature I've explored much

[wheresrhys]

I've added a test #95 which passes in node 5. I notice you have sendAsJSON in your code when it should be sendAsJson. I've managed to get it to pass in node 5 and 6

[tamird]

Good point regarding the key name, but this issue is about ArrayBuffer, not Buffer.

[tamird]

Ah, and it turns out I wrote the issue incorrectly - the actual code I wrote uses sendAsJson.

[wheresrhys]

I suggest raising this as an issue on node-fetch, which this library uses to construct responses. It already supports use cases that go beyond the fetch spec, so they could be keen to add support for ArrayBuffer

[tamird]

What does this have to do with the fetch spec? The fetch spec already supports ArrayBuffer on the response https://developer.mozilla.org/en-US/docs/Web/API/Body/arrayBuffer

[wheresrhys]

I assumed you were running the tests in node (as opposed to in a browser) as the error stack looks more like something generated in node. If this is the case then support for arrayBuffer needs to be added to node-fetch. node-fetch/node-fetch#51. Not everything defined in the fetch spec is implemented, or is even intended to be implemented (https://github.com/bitinn/node-fetch/blob/master/LIMITS.md), in node-fetch, but for most use cases it's similar enough.

[tamird]

What does this have to do with node-fetch? The error stack is entirely within fetch-mock.

[wheresrhys]

Ah I missed that sorry. I now have a failing test and will work on fixing it

[tamird]

Great! Any luck?

[wheresrhys]

I have a failing test, but I'm still looking into what the behaviour should be with regard to building a Body from binary data. The spec https://fetch.spec.whatwg.org/#bodies mentions that ReadableStream may change to be ReadableByteStream, which may have some bearing on it.

Other than that I need to update fetch-mock to use stream.pipe() and add a check body isn't an ArrayBuffer before trying to 'utf8' decode, which may be enough

[tamird]

This might become a ReadableByteStream object. While the type might change, the behavior specified will be equivalent since the hypothetical ReadableByteStream object will have the same members as the ReadableStream object has today.

What bearing would that have on the behaviour? Can you share your failing test? I'd like to help you get this over the finish.

[wheresrhys]

here you go https://github.com/wheresrhys/fetch-mock/compare/rhys/buffer

[tamird]

FWIW it seems that this mostly works in the browser already (as opposed to NodeJS), but there's still some weirdness in webkit as seen in https://github.com/cockroachdb/cockroach/pull/7178/files - still not quite sure what's going on there.

[wheresrhys]

closing due to incativity

[tamird]

Sorry, this was JakeChampion/fetch#351.

[qjflores]

was this implemented update fetch-mock to use stream.pipe()?

[wheresrhys]

@qjflores Please open a new issue if something is missing for you. I have very little memory of what this discussion was about