Giter Site home page Giter Site logo

Comments (5)

felixhammerl avatar felixhammerl commented on August 29, 2024

https:// should work. It appears that you tried to access the app without TLS, which we don't allow in production mode, see here: https://github.com/whiteout-io/mail-html5/blob/master/server.js#L94-L100

Can you confirm this?

from mail.

lazzarello avatar lazzarello commented on August 29, 2024

I have a proxy in front of the node.js app that is serving up https. Are you saying that the node.js app must run an HTTPS server? If so where do I configure the RSA key and x.509 certificate?

from mail.

tanx avatar tanx commented on August 29, 2024

Here is the code for the webserver config:

https://github.com/whiteout-io/mail-html5/blob/master/server.js#L70

The server is currently optimized for Deployment on Elastic Beanstalk on AWS. Specifically if the HTTP header X-Forwarded-Proto !== 'https' then the app will redirect requests to https://url. This is required because TLS is terminated at the Loadbalancer and traffic between the LB and the node.js host is over http.

I would suggest playing around with settings to find a configuration that suits your setup.

from mail.

lazzarello avatar lazzarello commented on August 29, 2024

Got it, thanks. I usually do this kind of redirection in the proxy server.

from mail.

tanx avatar tanx commented on August 29, 2024

I usually do this kind of redirection in the proxy server.

Agreed. This is an infrastructure detail. The problem is that Elastic Beanstalk is a PaaS stack, so it was the most straightforward solution to add the http header in the express server.

If you want to change the current solution to be more flexible, we'd be happy to accept a PR that moves the stuff you don't need for your setup to a config file. This way you could integrate upstream patches easier into your deployment.

https://github.com/whiteout-io/mail-html5/tree/master/config

from mail.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.