uptime fails for systems where --pretty not supported

[wick3dr0se]

uptime fails for systems where --pretty not supported

[wick3dr0se]

Upon merge of PR #20 this issue is fixed

[nathhad]

Confirmed fixed by pull request #20 and working (tested in place). Thanks!

[wick3dr0se]

commit 9eeaba1 changes if statement to read for uptime --pretty command instead. Thank you for the great work!

[nathhad]

commit 9eeeaba1 reverted the fix - command -v uptime --pretty does not successfully verify support for --pretty on busybox. So far the only thing I've found that clearly works is testing whether calling the command in question symlinks back to /bin/busybox.

[wick3dr0se]

I reopened the issue. Hoping we can find a way to print 'uptime' on busybox without path refrence to os

[nathhad]

Got it. One option, since there seem to have been other small systems that don't have the full version of uptime --pretty would be to just pull the raw uptime value (first field in /proc/uptime) and reformat it ourselves. That method is guaranteed to work the same on every Linux based system I've ever seen myself, and it's actually easier to process that value (which is just uptime in raw seconds) than trying to strip it out of the output of any of the uptime commands. Should only take a dozen lines of code, I don't have fetch handy to work directly but here is a code snippet you can use to extract, then format however you'd like:

#!/bin/bash
# Get raw seconds value
RAWSEC=$(cat /proc/uptime | awk '{print $1}')
# Cut off decimal
RAWSEC=${RAWSEC%\.*}
echo $RAWSEC
# Extract weeks
WEEKS=$((RAWSEC/604800))
REMSEC=$((RAWSEC%604800))
echo "$WEEKS weeks and $REMSEC seconds"
# Extract days
DAYS=$((REMSEC/86400))
REMSEC=$((REMSEC%86400))
echo "$WEEKS weeks, $DAYS days and $REMSEC seconds"
# Extract hours
HOURS=$((REMSEC/3600))
REMSEC=$((REMSEC%3600))
echo "$WEEKS weeks, $DAYS days, $HOURS hours and $REMSEC seconds"
# Extract minutes
MINUTES=$((REMSEC/60))
REMSEC=$((REMSEC%60))
echo "$WEEKS weeks, $DAYS days, $HOURS hours, $MINUTES min and $REMSEC seconds"
# format it however you like
echo "Compare to output of uptime --pretty:"
uptime --pretty

That produces the following terminal output:

chuck@vapor:~/code$ ./uptime.sh
5972231
9 weeks and 529031 seconds
9 weeks, 6 days and 10631 seconds
9 weeks, 6 days, 2 hours and 3431 seconds
9 weeks, 6 days, 2 hours, 57 min and 11 seconds
Compare to output of uptime --pretty:
up 9 weeks, 6 days, 2 hours, 57 minutes

Once you strip out my comments, you can use that to extract a time pattern that works on any system, even the tiny ones like Alpine and OpenWRT, no doubts.

[wick3dr0se]

Check out commit de093b4