Comments (3)
I think we have to keep the current behaviour and throw an exception if there are transfer errors. This helped us identify the MRRC caching issue and it's better than masking the problem and not discovering potential issues. If you expect to find only specific artifacts in a repo, the channel configuration should have the streams listed (Example [1]: "eap8-amq-channel" and "eap8-insights-channel")
[1] https://gitlab.cee.redhat.com/jboss-set/channel-definitions/-/raw/main/eap-8.0.x/latest/channel.yaml
from wildfly-channel.
Thinking about this I'm not sure what is the correct behaviour. In this scenario, if one of the repositories is returning errors, we don't know if that repository have any artifacts versions to contribute. If we return partial results we might be getting wrong version of artifact or, even worse the manifest, without any means to really inform the user apart from a log message that can be disabled.
So in this case it feels like throwing exception if there are any transfer errors is the right thing to do... @ivassile, @jmesnil WDYT?
from wildfly-channel.
I'm going to close this, as I think the behaviour is correct
from wildfly-channel.
Related Issues (20)
- Verify the integrity of components coming from channels
- Splitting channel metadata into Channel and Manifest files HOT 3
- Clarification on Stream.version HOT 3
- Fix link to json-schema HOT 1
- Verify manifest ID has only valid characters
- Allow configuring maven checksum policy via a system property
- Add contributing and other community docs to wildfly-channel
- HttpProxy cannot set setURLStreamHandlerFactory when Prospero is used under a modular environment.
- During version resolution, MavenVersionResolver ignores versions deployed locally even if the same version is available in remote
- Use matrix builds in the 'main.yaml' GitHub Actions workflow; test SE 11, 17, 21
- Combining multiple channels fails when `resolve-if-no-stream: maven-release` is used
- Support versionPatterns in blocklists
- Incorrect resolution of the latest manifest from G:A HOT 3
- Required channel load order HOT 4
- Streams for artifacts with classifiers HOT 2
- Parralel resolution of available versions HOT 4
- Cannot create instance of class org.wildfly.channel.maven.ChannelCoordinate
- Support a blocklisting of excluded artifact versions HOT 3
- Advanced Maven resolution strategies HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wildfly-channel.