Giter Site home page Giter Site logo

Comments (12)

Wildhoney avatar Wildhoney commented on August 19, 2024

It actually seems to work for me @goffle 👍

Tested in Chrome and Opera.

from reactshadow.

Wildhoney avatar Wildhoney commented on August 19, 2024

Should work just fine with the updated version.

from reactshadow.

wontwon avatar wontwon commented on August 19, 2024

I can't quite figure out how to get font-awesome to import correctly into my shadow dom. I tried using the same code as above, but was unsuccessful.

from reactshadow.

Wildhoney avatar Wildhoney commented on August 19, 2024

You just need to import the CSS document into the shadow root: https://codesandbox.io/s/dark-voice-snrrc?file=/src/App.js

Op's code is from an older version of react-shadow.

from reactshadow.

wontwon avatar wontwon commented on August 19, 2024

@Wildhoney Thanks for your quick response! I'm not sure if the link you sent me is working. This is what I am currently seeing when I open your link.

2020-08-02 08 35 57

Do you see something different?

from reactshadow.

Wildhoney avatar Wildhoney commented on August 19, 2024

Hmm yep: https://imgur.com/jOjJ8vk

Anything in the console such as the fonts failing to load?

from reactshadow.

wontwon avatar wontwon commented on August 19, 2024

Weird @Wildhoney. I'm not seeing any requests to font-awesome. Here's my logs and network tab.

2020-08-02 10 07 53
2020-08-02 10 08 41

from reactshadow.

wontwon avatar wontwon commented on August 19, 2024

Can confirm. Had a friend open your link @Wildhoney on his machine and just a squared showed instead of the icon. Not sure whats going on.

from reactshadow.

Wildhoney avatar Wildhoney commented on August 19, 2024

Sorry maybe it's because I put class instead of className? Although still strange how it showed for me.

Is this any better: https://codesandbox.io/s/pedantic-colden-h6qtt

from reactshadow.

ivnmaksimovic avatar ivnmaksimovic commented on August 19, 2024

Using Chrome browser, I can see only square on this link https://codesandbox.io/s/pedantic-colden-h6qtt. And I do see font downloaded successfully in network tab. But just tried in Safari and I can see the camera icon.

from reactshadow.

Wildhoney avatar Wildhoney commented on August 19, 2024

Is your version of Chrome somewhere around 84.0.4147.105?
And what happens if you change root.div to just div?

from reactshadow.

ivnmaksimovic avatar ivnmaksimovic commented on August 19, 2024

Chrome is Version 84.0.4147.105 (Official Build) (64-bit). If I change root.div to div, I can see the camera icon.

from reactshadow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.