Giter Site home page Giter Site logo

Comments (10)

Wildhoney avatar Wildhoney commented on August 19, 2024

Do you get the same error with the polyfill

from reactshadow.

basherr avatar basherr commented on August 19, 2024

@Wildhoney Yup the error doesn't seem to fix even having pollyfill

from reactshadow.

SpeedoPasanen avatar SpeedoPasanen commented on August 19, 2024

Wasn't createShadowRoot deprecated a long time ago?

from reactshadow.

basherr avatar basherr commented on August 19, 2024

@funkizer It is deprecated but pollyfill seems to fix this issue with firefox but not with edge.

from reactshadow.

SpeedoPasanen avatar SpeedoPasanen commented on August 19, 2024

Yeah. Polyfills aren't meant to return dropped features. It was deprecated some 2 years ago in favor of: https://developer.mozilla.org/en-US/docs/Web/API/Element/attachShadow

from reactshadow.

Wildhoney avatar Wildhoney commented on August 19, 2024

It's only complaining about createShadowRoot because it's the fallback.

Using webcomponents-sd-ce.js there should be no reason why attachShadow wouldn't be polyfilled.

from reactshadow.

basherr avatar basherr commented on August 19, 2024

@Wildhoney We however added the pollyfill for firefox which doesn't seems to work and we've tried changing dom.webcomponents.enabled to true in about:config section which seems to be fixed but as always it isn't solution to the problem. Could there anything I'm missing with firefox 58.0?

from reactshadow.

Wildhoney avatar Wildhoney commented on August 19, 2024

Hmm.

The example uses the polyfill.

It seems to work just fine for me in Firefox 58. Not for you?

from reactshadow.

pactera-admindev-remy avatar pactera-admindev-remy commented on August 19, 2024

I did as you did, it fixed the createShadowRoot problem but another one poped up instead on Firefox (No problem on Chrome/Safari)

TypeError: Argument 1 of EventTarget.dispatchEvent does not implement interface Event.
This bug is related to "webcomponents.js": "~0.7.24" polifyll not to ReactShadow though...

from reactshadow.

Wildhoney avatar Wildhoney commented on August 19, 2024

Not supporting older versions of shadow roots any more.

from reactshadow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.