I used Microsoft's new Theme Converter to convert `Plastic` to a Visual Studio theme =)

[will-stone]

I used Microsoft's new Theme Converter to convert `Plastic` to a Visual Studio theme =)

[will-stone]

Yeah they don't look great 😬 It's probably best to make it manually and match tokens: https://github.com/will-stone/plastic/blob/main/themes/vscode/src/theme.ts#L271

[GavinRay97]

Yeah, agreed.

Btw, I noticed this line in the code:

plastic/themes/vscode/src/theme.ts

Lines 32 to 33 in 0e46eba

	// TODO is there an official theme type that can be used for the return type?
	export function getTheme(deprioritised = false): unknown {

I took the contents of the JSON file produced by Developer: Generate Color Theme From Current Settings and put it into Quicktype:

• https://app.quicktype.io
• File: Plastic.json.txt

Here you go 🙂
(Probably not entirely correct, but should be close and better than nothing)
https://gist.github.com/GavinRay97/241fd0797f223a2db0dc1114c2122a37

[will-stone]

Thanks @GavinRay97 However, it'd be great to have an official type so we know the ThemeColors keys are always up-to-date and it can be used to find missing keys.

[GavinRay97]

For sure -- if we can find the location of the JSON schema being referenced with vscode://schemas/color-theme, then we can generate TypeScript definitions from that.

---

EDIT: Wow, it looks like MS is doing this pretty weird actually.

Have a look here:

• https://github.com/microsoft/vscode/blob/94c9ea46838a9a619aeafb7e8afd1170c967bb55/src/vs/workbench/services/themes/common/colorThemeSchema.ts#L204-L245
• https://github.com/microsoft/vscode/blob/94c9ea46838a9a619aeafb7e8afd1170c967bb55/src/vs/platform/theme/common/colorRegistry.ts#L163-L186

I think you might be able to get the JSON schema output by writing an extension with this content. May give it a shot later just to see:

let schemaRegistry = Registry.as<IJSONContributionRegistry>(JSONExtensions.JSONContribution);
console.log(schemaRegistry.schemasById)

const workbenchSchema = schemaRegistry.schemasById["vscode://schemas/workbench-colors"]
const colorThemeSchema = schemaRegistry.schemasById["vscode://schemas/color-theme"]

colorThemeSchema.ts

export const colorThemeSchemaId = 'vscode://schemas/color-theme';

const colorThemeSchema: IJSONSchema = {
	type: 'object',
	allowComments: true,
	allowTrailingCommas: true,
	properties: {
		colors: {
			description: nls.localize('schema.workbenchColors', 'Colors in the workbench'),
			$ref: workbenchColorsSchemaId,
			additionalProperties: false
		},
     // <SNIPPED>
    }
};

export function registerColorThemeSchemas() {
	let schemaRegistry = Registry.as<IJSONContributionRegistry>(JSONExtensions.JSONContribution);
	schemaRegistry.registerSchema(colorThemeSchemaId, colorThemeSchema);
	schemaRegistry.registerSchema(textmateColorsSchemaId, textmateColorSchema);
}

colorRegistry.ts

const colorRegistry = new ColorRegistry();
platform.Registry.add(Extensions.ColorContribution, colorRegistry);

export function registerColor(id: string, defaults: ColorDefaults | null, description: string, needsTransparency?: boolean, deprecationMessage?: string): ColorIdentifier {
	return colorRegistry.registerColor(id, defaults, description, needsTransparency, deprecationMessage);
}

export function getColorRegistry(): IColorRegistry {
	return colorRegistry;
}

// ----- base colors

export const foreground = registerColor('foreground', { dark: '#CCCCCC', light: '#616161', hc: '#FFFFFF' }, nls.localize('foreground', "Overall foreground color. This color is only used if not overridden by a component."));
export const errorForeground = registerColor('errorForeground', { dark: '#F48771', light: '#A1260D', hc: '#F48771' }, nls.localize('errorForeground', "Overall foreground color for error messages. This color is only used if not overridden by a component."));
export const descriptionForeground = registerColor('descriptionForeground', { light: '#717171', dark: transparent(foreground, 0.7), hc: transparent(foreground, 0.7) }, nls.localize('descriptionForeground', "Foreground color for description text providing additional information, for example for a label."));
export const iconForeground = registerColor('icon.foreground', { dark: '#C5C5C5', light: '#424242', hc: '#FFFFFF' }, nls.localize('iconForeground', "The default color for icons in the workbench."));

export const workbenchColorsSchemaId = 'vscode://schemas/workbench-colors';

let schemaRegistry = platform.Registry.as<IJSONContributionRegistry>(JSONExtensions.JSONContribution);
schemaRegistry.registerSchema(workbenchColorsSchemaId, colorRegistry.getColorSchema());

---

It looks like at least the Developer: Generate Color Theme From Current Settings exports every setting:

• https://github.com/microsoft/vscode/blob/d4c222488de817d491f7c5686cf1161e9cceb7d4/src/vs/workbench/contrib/themes/browser/themes.contribution.ts#L286-L336

[will-stone]

That certainly is complex. Thanks for doing the research. I'm going to close this as it looks like a Visual Studio theme would require manual building.