Comments (4)
I think ansible-review should use the standard ansible.cfg mechanism, so it might be that we're just not checking for the presence of that configuration parameter when decrypting vault files.
For now I'll have to mark this as a bug and hope someone can help solve it until I have some more time to dig into it.
from ansible-review.
Is this a bug on the latest 0.14.0rc2 ? I think I have hit this problem when the file is completely vaulted. For now I prefer encrypt_string instead of vaulted files anyway, so I believe this latest RC works with that.
As for the ansible.cfg
reference, I don't agree with that because most often we are linting our ansible role repo, which does not include the ansible.cfg (since its typically in the playbook repo). For now, I think ansible-review shouldn't raise an ERROR and prevent the commit when it hits a vaulted file. It should be a warning.
from ansible-review.
@ansiblejunky it shouldn't be now but I don't use vaulted files these days so I'm not sure I've tested it - like you, I find the encrypt_string makes for much more readable configuration and definitely more useful diffs!
from ansible-review.
@willthames Oh I totally agree with you and I haven't done vaulted files for awhile either, however thought you might want to know about a bug that a colleague hit when using vaulted files.
from ansible-review.
Related Issues (20)
- Octal Permission representation HOT 1
- Add custom ID to Standard
- Bug using get_action_tasks
- Classification of files as group_vars not working correctly HOT 3
- Python 3 support HOT 3
- AttributeError: 'InventoryManager' object has no attribute 'get_group' HOT 2
- Unable to Load Variables from Directories within defaults/main HOT 1
- Broken PyPI metadata and related problems HOT 3
- Embrace parseable output to stdout HOT 4
- Broken EXTRA0008 check HOT 3
- ansible review with git diff sometimes aborts on non yaml files, non yaml should be skipped
- Warnings vs Errors HOT 4
- Stacktrace when providing custom config file using ansible-review 0.14.0rc1 HOT 1
- Inconsistent output in pre-commit hook compared to other hooks HOT 1
- Support for pre-commit hook `verbose` option
- Inconsistent output from ansible-review for some rules
- release 0.14rc2 produces stack trace when trying to read vaulted file
- ansible-review v0.14.0rc2 produces stacktrace when checking azure_rm.yml inventory plugin HOT 1
- Stack trace/error upon finding vault string in playbook vars HOT 1
- cannot import name 'default_rulesdir' from 'ansiblelint' HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ansible-review.