'total' seems to be an ABS value rather than going negative in a count-down

[wimbarelds]

'total' seems to be an ABS value rather than going negative in a count-down

[oucil]

I've forked and will try a couple things and hopefully shoot up a pull req soon, just a quick question to save some time...

I see on line 215, 216 you've used Math.abs(), just curious if you've tried Math.round() already and seen any adverse affects?

[wimbarelds]

The benefit of not using round there, is that if you do- the circle animation can only update once per second.

Also, I agree that total should not be an abs value, so I'm committing a fix for that now.

See:
21a7298

[oucil]

FYI, the effect of this change has altered the value of total in a Count-down scenario to a negative prior to reaching zero and a positive post zero, that would affect anyone previously testing for a positive value, you may want to update the docs for that. Count-up is not affected, it's always zero.

[wimbarelds]

That's a good point. Actually makes me think whether or not I should reverse that (negative after 0?). I think the most conventional use is "count down", in which case total is the "time left until".

[oucil]

I think that would be more intuitive, and probably affect a smaller number of users based on the typical use case like you point out.

[oucil]

Found one other quirk, this is prior to reversing the neg/pos you want to do though, so you may want to test... when doing a count-down, I exposed an input field with id="timer-count" and then added $('#timer-count').val(total); and noticed that the negative numbers were one behind (i.e. the timer shows 10, but the input shows -11), it would linger at 0 for 2 seconds, and then the positive numbers would all be correct.