Comments (4)
Excuse me if I expressed myself poorly.
When receiving an envelope with a counter don't we want to remove a value with fitting counter from our messagekeys only after a successful message decryption? Otherwise an attacker could just create envelopes with a valid sessiontag and force a party to remove all his saved messagekeys by iterating over counter.
from proteus.
remove(i)
will also return the removed value, the (unwrapped) result is stored in mk
. The HMAC is then verified using mk
.
from proteus.
Sorry, I misunderstood. I see what you mean now. I think this is fine, because we work on a copy of a session state that was created here:
https://github.com/wireapp/proteus/blob/develop/src/internal/session.rs#L537
If the decryption fails, the copy of the session state is not saved in https://github.com/wireapp/proteus/blob/develop/src/internal/session.rs#L542.
from proteus.
I'm assuming this issue is resolved and will close it.
from proteus.
Related Issues (8)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proteus.