🐛 BUG: 0.1.0-next.3 is much slower than 0.0.12 - hangs vscode temporarily

[withastro]

🐛 BUG: 0.1.0-next.3 is much slower than 0.0.12 - hangs vscode temporarily

[jasikpark]

I'm glad to see that synckit seems to dramatically improve things! v0.1.0-next.4 runs about the same speed as 0.0.11 for me 😁

[antonyfaris]

Hi, thanks for opening this issue. We are aware of this problem. This happens due to the package make-synchronous that we use while we wait for Prettier to support esm. next is a pre-release meant for testing. I suggest you keep using latest for production.

[hayley]

Thanks for the quick reply!

I had run into a transient error earlier in the upgrade using latest on the project so I thought maybe that next was the way to go for 0.25, but since that seems resolved (may have been a temporary syntax error I introduced when upgrading), I'll keep using latest for now.

Thanks again!

[jasikpark]

Hi, thanks for opening this issue. We are aware of this problem. This happens due to the package make-synchronous that we use while we wait for Prettier to support esm. next is a pre-release meant for testing. I suggest you keep using latest for production.

Is that b/c @astrojs/compiler doesn't support cjs?

[jasikpark]

Thankfully it looks like prettier is working on transitioning to support esm: prettier/prettier#10157 (comment)

[jasikpark]

https://github.com/prettier/prettier/pull/12343/files might be a good case study in how to write it 🤔

[jasikpark]

Also tracked by prettier/prettier#4459 which would make the parser async?

[jasikpark]

https://github.com/rx-ts/synckit suggested in prettier#4459 might be a faster solution in the meantime than make-synchronous: prettier/prettier#4459 (comment)

[antonyfaris]

Is that b/c @astrojs/compiler doesn't support cjs?

Yes, that's correct.

Thankfully it looks like prettier is working on transitioning to support esm: prettier/prettier#10157 (comment)

Also tracked by prettier/prettier#4459 which would make the parser async?

Yeah, we are keeping an eye on those issues.

https://github.com/prettier/prettier/pull/12343/files might be a good case study in how to write it 🤔

https://github.com/rx-ts/synckit suggested in prettier#4459 might be a faster solution in the meantime than make-synchronous: prettier/prettier#4459 (comment)

Thank you for the suggestions!

[Princesseuh]

Closing at this has been fixed in v0.1.0-next.4. Performance is still not perfect, however it's much much better than before