Giter Site home page Giter Site logo

Comments (16)

explorigin avatar explorigin commented on May 18, 2024 10

Hey guys, I just wanted to say Thanks! This is a much needed package in the RN space. Please pass on my gratitude to your respective employers for offering your time in such a way that we can all benefit from.

from react-native-navigation.

DanielZlotin avatar DanielZlotin commented on May 18, 2024 2

Breaking changes:

Nothing in native (we hide the implementation for you in our NavigationApplication), but when moving your project to RN31, you should know about a few RN breaking changes:

  • importing React, {Component, PropTypes} must be from react and not react-native (used to throw warning, will blow up now)
  • ActivityIndicatorIOS is deprecated, replace with ActivityIndicator (both platforms are supported now)
  • specifying flex: 1 in places that you don't need it will now break your ui completely
  • specifying flexWrap: wrap without alignItems: flex-start will now break your ui

from react-native-navigation.

DanielZlotin avatar DanielZlotin commented on May 18, 2024 1

By soon, I mean we plan doing it next Monday. No guarantees yet.

from react-native-navigation.

AdamBrodzinski avatar AdamBrodzinski commented on May 18, 2024 1

@DanielZlotin Great to hear! and keep up the great work!! If there's anything I can test specifically let me know, going to try this out tomorrow. 👍

from react-native-navigation.

musicode avatar musicode commented on May 18, 2024

is it complete?

from react-native-navigation.

explorigin avatar explorigin commented on May 18, 2024

No, this is an issue to track the process.

from react-native-navigation.

musicode avatar musicode commented on May 18, 2024

how long to wait for it?

from react-native-navigation.

DanielZlotin avatar DanielZlotin commented on May 18, 2024

iOS is completed (RN31)
Working on Android

from react-native-navigation.

musicode avatar musicode commented on May 18, 2024

iOS RN32 available?

from react-native-navigation.

DanielZlotin avatar DanielZlotin commented on May 18, 2024

No, we have a weird bug when using anything higher than 31 on iOS. see https://github.com/wix/react-native-navigation/issues/257

from react-native-navigation.

DanielZlotin avatar DanielZlotin commented on May 18, 2024

update: RN31 works great on iOS, works OK on Android.

There are indications of memory issues on Android but that's probably related to the temp hack we did with view unmounting/detaching that we need to remove. Easy peasy.

from react-native-navigation.

bbrock25 avatar bbrock25 commented on May 18, 2024

@DanielZlotin will you be releasing a version bump for this in the near future?

from react-native-navigation.

DanielZlotin avatar DanielZlotin commented on May 18, 2024

@bbrock25 iOS is already out (with the controllers update), Android should be soon. Unfortunately, we are blocked by the fact we use this framework along with lots of other libraries in production, some of which do not support RN>25. we are working hard on migrating.

from react-native-navigation.

musicode avatar musicode commented on May 18, 2024

By soon, I mean we plan doing it next Monday. No guarantees yet.

how about RN32?

from react-native-navigation.

DanielZlotin avatar DanielZlotin commented on May 18, 2024

@musicode as said in https://github.com/wix/react-native-navigation/issues/257#issuecomment-242979908 - I started seeing weird issues of views not appearing when going from 31 to 32 on iOS. So as I see it now, we will upgrade to RN31 first in order not to jump too high all at once.

from react-native-navigation.

DanielZlotin avatar DanielZlotin commented on May 18, 2024

updated to RN31 in v2.0.0-experimental.91.
We need to remove some left over hacks, I'll open a separate issue. Please report any resulting difficulties.

from react-native-navigation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.