Giter Site home page Giter Site logo

Comments (5)

johnjohndoe avatar johnjohndoe commented on June 21, 2024 1

I close this issue since we decided that the location field is optional.

from wo-ist-markt.github.io.

torfsen avatar torfsen commented on June 21, 2024

Is there a reason why location cannot be null? In my understanding it always was an optional field that could be used to specify the precise location in case the (mandatory) title was not enough. In the cases you listed the title is precise enough, so there's no need for further information.

See also #27.

from wo-ist-markt.github.io.

johnjohndoe avatar johnjohndoe commented on June 21, 2024

In an ideal data setup title should contain the well known name of the market as in Kirchenmarkt Rüppurr or a type qualifier as in Trödelmarkt Oberreut. The location field should provide detailed address information as in Auf dem Julius-Leber-Platz or Vor der Christ-König-Kirche.

from wo-ist-markt.github.io.

torfsen avatar torfsen commented on June 21, 2024

I see you point, but on some markets there is simply no difference between these two. Of course I can use a title of Wochenmarkt Werderplatz and a location Auf dem Werderplatz, but for me that's just clutter compared to simply using a title of Werderplatz, in particular since we only cover traditional farmer markets in Karlsruhe.

I like your addition of a validation step, but I do think that we should keep location optional.

from wo-ist-markt.github.io.

johnjohndoe avatar johnjohndoe commented on June 21, 2024

@torfsen I refactored the validator to differentiate between warnings and errors.

from wo-ist-markt.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.