Cross-origin restriction circumvention?

[wofwca]

Cross-origin restriction circumvention?

[LoneCoder21]

Oh i see. I had this issue in my extension too so I'll just use this option 😞

[LoneCoder21]

wait how did u detect the likelihood of media being unsupported?

[WofWca]

@LoneCoder21

It's this check

jumpcutter/src/entry-points/content/helpers/isSourceCrossOrigin.ts

Line 37 in 81b4e50

return elCurrentSrcUrl.origin !== document.location.origin;

See the comment:

jumpcutter/src/entry-points/content/AllMediaElementsController.ts

Lines 96 to 115 in c63821f

	function getAppropriateControllerType(
	settings: Pick<Settings, typeof controllerTypeDependsOnSettings[number]>,
	elementSourceIsCrossOrigin: boolean,
	): ControllerKind {
	// Analyzing audio data of a CORS-restricted media element is impossible because its
	// `MediaElementAudioSourceNode` outputs silence (see
	// https://webaudio.github.io/web-audio-api/#MediaElementAudioSourceOptions-security,
	// https://github.com/WofWca/jumpcutter/issues/47,
	// https://html.spec.whatwg.org/multipage/media.html#security-and-privacy-considerations),
	// so it's not that we only are unable to analyze it - the user also becomes unable to hear its sound.
	// The following is to avoid that.
	//
	// Actually, the fact that a source is cross-origin doesn't guarantee that `MediaElementAudioSourceNode`
	// will output silence. For example, if the media data is served with `Access-Control-Allow-Origin`
	// header set to `document.location.origin`. But currently it's not easy to detect that. See
	// https://github.com/WebAudio/web-audio-api/issues/2453.
	// It's better to not attach to an element than to risk muting it as it's more confusing to the user.
	return elementSourceIsCrossOrigin && settings.dontAttachToCrossOriginMedia
	? ControllerKind.ALWAYS_SOUNDED
	: settings.experimentalControllerType

So it's not like we detect an actual likelihood expressed as a number between 0 and 100%, but rather "it's cross-origin, so it's probably not gonna work".