i18n: numberFormat

[woocommerce]

i18n: numberFormat

[ryelle]

Looks like there's a core javascript function we can use for this: Intl.NumberFormat() – and we only need to know the currency of the number + locale code 👍 Seems well supported in browsers too.

[timmyc]

For context, JetPack uses i18n-calypso

Seems reasonable to use it here as well.

[timmyc]

Chatted a bit with @ryelle about this topic today, and she brought up an excellent point that is might be a good instance where we could potentially contribute something back to Gutenberg/Core. JavaScript i18n is still in development in core, and numberFormat as you noted is missing right now.

So in lieu of taking the easy road by using i18n-calypso.numberFormat() we could consider porting the logic ( which appears pretty simple ) to wp.i18n.

Seems like the items needed can be groked from $wp_locale. Counterpart wp core code can be seen here

[timmyc]

Did a quick look at gutenberg again today to see if there was any hidden features around this, and at least in the word count component, there is no i18n on numbers happening:

[timmyc]

Great find @ryelle - since we only need to support IE11 and > # I think this will work perfectly - going to close out this issue