Customizable Credit Card Icons

[woocommerce]

Customizable Credit Card Icons

[roykho]

There is already a filter for that https://github.com/woothemes/woocommerce-gateway-stripe/blob/master/includes/class-wc-gateway-stripe.php#L101

[BFTrick]

There's a filter (which I pointed out to the user) but many of these users don't have coding skills. :(

We should add a bit of UI to make it possible for those users to customize.

[roykho]

I am not sure if adding additional UI for edge case is worth maintaining as majority of the people will not need to change this. In addition, adding this UI will mean we need to add it to all our payment gateways.

I understand most people may not be code savvy, however if we put this in our documentation with steps to add the code, it should suffice. We simply can't add every possible UI option just based on people may not know how to add code. That's like saying we should add UI options for every filter we have for all our products.

On the other hand if however more than 50% of the people need to filter this out, than yes I would agree that this should be made a UI option.

cc @gedex your thoughts on this?

[gedex]

yeah, I agree that we need to consider this when the demand is high. For now, we could improve our documentation to mention the filter. I'll keep this open in case similar request is coming.

[BFTrick]

I'm fine with that. Let's see if other users have this issue.

Can you update the docs with the filter? Or let the docs people know what to do?

[pmciano]

Along the same lines, if a user doesn't have Enable Stripe Checkout checked off, the credit card image still shows the Bitcoin icon, even though you can only enter Bitcoin information through Stripe Checkout:

If the credit card images shown were easily customizable, the user would be able to remove the Bitcoin image when Stripe Checkout is disabled, since it is superfluous.

[roykho]

@pmciano in this case bitcoin icon should be removed if not supported.

[robin-scott]

This cropped up in a mobile checkout here, whereby client wanted to remove diners and JCB logos (neither of which they recognized fwiw!!) as these flow onto two lines in a mobile checkout... I feel like this setting could be a useful, albeit low priority, addition.

What's more edge case: actually having one of those cards, or wanting to remove them from displaying in your checkout!

[roykho]

@silicondales - as you can see more than a year ago this issue was opened and yet to have anyone else needing to have this as a full on UI setting. Most likely a filter will suffice. In addition, in our next Stripe 4.0 update, you will have much better control over what is shown through the filter which we will document.

[robin-scott]

yeah absolutely - I agree its super low priority. Docs don't exist (that I can see), so I wrote some https://silicondales.com/tutorials/woocommerce-tutorials/remove-obscure-payment-logos-icons-woocommerce-stripe-gateway/ - though even this would be beyond the novice dev in my opinion.