Comments (7)
fixed with #67
from woocommerce-gateway-stripe.
Ok so my test was before token was checked again on this line https://github.com/woothemes/woocommerce-gateway-stripe/blob/master/assets/js/stripe.js#L73
That gave me false positives with the one
implementation as it did indeed reduce the event being fired but not the one we want. My assumption currently is that WC "perhaps" re-generates the form on AJAX thus re-binding the event again and thus making any other logic moot such as off
. This is just an assumption but will investigate more.
from woocommerce-gateway-stripe.
the reason it's fired twice comes is noted in my first post - but guess i'll take a look at how other gateways handle it :P - or why we need to watch on both events ^^
from woocommerce-gateway-stripe.
Actually in my test it is fired more than 4 times and using one
solves the issue of cutting it in half which now fires once per event type as stated in the one
documentation. However I have since removed that as that doesn't solve your original issue which I originally thought was the culprit. For example if you removed "submit" as one of the events, you will see it is still firing twice.
from woocommerce-gateway-stripe.
Thats intresting in my setup with storefront it's only fired twice - with and without the multi step checkout but had to tweak a check to pass the first submit of the multi step checkout ^^
from woocommerce-gateway-stripe.
Does onsubmit
fire only twice for you? Or just the XHR call to Stripe?
from woocommerce-gateway-stripe.
if i remeber correctly from my js debugging for reporting the issue it was one XHR from submit
one from checkout_place_order_stripe
from woocommerce-gateway-stripe.
Related Issues (20)
- [BNPL] Accept Afterpay payments
- Use separate Stripe Payment Elements for card and link to prevent credit card purchases being created as "Link" payments HOT 1
- Admin area timing out with Stripe 8.1.1 HOT 1
- Implement filters to customize UPE field styles HOT 2
- Implement filters to localize card field placeholder text
- Consider replacing FILTER_SANITIZE_STRING, since it is deprecated as of PHP 8.1.0 HOT 2
- Back-office fatal error in function /wp-content/plugins/woocommerce-gateway-stripe/includes/class-wc-gateway-stripe.php HOT 1
- Disable card brand selection when UPE is disabled
- [BNPL] Klarna / Affirm - No error message is displayed on the block checkout when the transaction is denied HOT 2
- [APM] Charge ID on the Edit order page isn't linking to the Stripe dashboard
- Improve Stripe account ID display
- [APM] Wrong redirection destination when the payment fails on the Pay for order page
- Duplicated WP notice for Multibanco when the store currency isn't EUR
- Incorrect payment method ID set on subscriptions if processing UPE redirect fails HOT 2
- [Klarna] Improve handling of unsupported merchant account countries HOT 2
- Mandate interval is case sensitive but output is not checked for casing, potentially causing subscription renewal failure
- Stripe Refund Webhook not setting order to Refunded HOT 1
- [Deferred intents] Duplicate stripe meta on orders caused by handling the redirect flow and webhook event at the same time
- Wrong customer info sent to stripe.com
- Confirm the behavior of SEPA Debit Sources used as a PaymentMethod HOT 17
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from woocommerce-gateway-stripe.