Comments (10)
After chatting with @daniloercoli, this also seems to be working on Android and should be ok once we fix #135
from gutenberg-mobile.
Keeping track of all focus-related issues in #196
from gutenberg-mobile.
@diegoreymendez @daniloercoli can you update this one by Wednesday with what we need to do to ensure this and how much it should take?
from gutenberg-mobile.
Let's also consider #135 as part of this
from gutenberg-mobile.
There are a couple of problems with focus handling on the Android side.
I know @mzorz was working on a fix for them, but I'm not quite sure the current state of the fix. IIRC the problem was with our react-native-recyclerview-list
implementation, that was acting badly under some circumstances.
Once those "focus" problems are solved, I think we need to modify Aztec + Aztec Wrapper to correctly move the cursor to the position tapped by the user.
from gutenberg-mobile.
It's a bit complicated because I'm not sure what's needed for this. But assuming:
- Discovery work to learn what's necessary. (1 day)
- Initial implementation. (2 days)
- Testing / fixing issues (1 or 2 days)
I'd say 5 days would be my initial estimation.
Does this work for you @koke?
from gutenberg-mobile.
Actually @koke, I assumed work was necessary in iOS, but it seems like it works out of the box.
Can you review and confirm if this behavior is fine for the purpose of this issue?
from gutenberg-mobile.
@diegoreymendez yeah, that looks like it works as expected. Great news
from gutenberg-mobile.
After chatting with @mzorz we are estimating 3 days for #135, although he might come up with a better estimate after more research today.
from gutenberg-mobile.
I removed myself from the assignment since there's nothing else I can do for this task right now.
from gutenberg-mobile.
Related Issues (20)
- Paragraph Block: Enable Drop Cap
- React Native Upgrade 0.69 - Implement Gutenberg changes
- JavascriptException: TypeError: Cannot read property 'tagName' of undefined HOT 3
- Text added with iOS dictation disappears HOT 17
- Compile and target Android API 31 HOT 3
- Stop media upload button is missing in iOS Picker HOT 1
- Investigate issues with React Native Gesture Handler `2.5.0` HOT 1
- Move Gutenberg Editor Unsupported Block Editor Tests to the main apps HOT 2
- Current E2E Tests - Tracking Issue HOT 4
- Block options title shows "undefined" instead of block type HOT 1
- Add E2E test to test the block editor settings endpoint functionality HOT 1
- Fix Jetpack Build issues HOT 5
- RCTFatalException: Unhandled JS Exception: TypeError: undefined is not an object (evaluating 'b[W].width') This error is loc...: Unhandled JS Exception: TypeError: undefined is not an object (evaluating 'b[W].width') HOT 3
- RCTFatalException: Unhandled JS Exception: TypeError: l is not a function. (In 'l()', 'l' is undefined): Unhandled JS Exception: TypeError: l is not a function. (In 'l()', 'l' is undefined), stack: HOT 5
- RCTFatalException: Unhandled JS Exception: TypeError: undefined is not an object (evaluating 'n.forEach') This error is loca...: Unhandled JS Exception: TypeError: undefined is not an object (evaluating 'n.forEach') HOT 9
- Gallery block outline overlaps block HOT 5
- Android - Emoji not showing up correctly after updating Appcompat in older OS HOT 3
- Upload - Pass VideoPress GUID in media upload events [WP-iOS]
- Upload - Pass VideoPress GUID in media upload events [WP-Android]
- Story block fails to preview and play videos HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gutenberg-mobile.