Comments (3)
I was able to reproduce this on both platforms following the steps above, but it seems like a rare circumstance. I did not note any other sentry events that weren't from internal testing, but I could have missed them within the grouped Sentry issue.
I traced the exception back to this code in block.native.js, where blockType.getWrapperEditProps
was being accessed when blockType
did not exist. I then noted the web implementation adds logic to check if blockTypes
exists before getting wrapperProps
.
The fix proposed in WordPress/gutenberg#56846 prevents the crash and improves alignment with web behavior. I'm wondering if it's the best fix, however, as we haven't encountered this error with other blocks. It may have something to do with the <!-- wp:jetpack/paywall /-->
block name, and these changes to unregister this block when the postType is a page: Automattic/jetpack@014b087. I tried investigating from the Jetpack side within the paywall block, but did not note anything that would resolve the crash.
@fluiddot @geriux I requested review on the PR if you have any suggestions.
from gutenberg-mobile.
The first time I spotted this crash was when checking JavaScript exceptions in version 23.7-rc-1
of the Jetpack Android app (reference).
from gutenberg-mobile.
Fixed in WordPress/gutenberg#56846.
from gutenberg-mobile.
Related Issues (20)
- RCTFatalException: Unhandled JS Exception: Error: , ): Expected color definition This error is located at: in U in R...: Unhandled JS Exception: Error: , ): Expected color definition HOT 1
- [Android] Media Upload progress bar does not increment HOT 2
- Excerpts shows the VideoPress URL for VideoPress v5
- Empty state when using source URL of VideoPress vide in v5 block
- VideoPress v5: Plays inline setting not saving for Atomic sites w/o VideoPress HOT 1
- Support HTML anchors HOT 3
- Cover block: Videos can't be played in private sites
- Add ability to transform video block to VideoPress
- VideoPress v5: Investigate cases where app markup differs to the web
- Long delay when saving a post HOT 3
- Editor crashes when the content of a synced pattern is updated HOT 2
- Improve appearance of the File Block
- RuntimeException: android.os.TransactionTooLargeException: data parcel size 836080 bytes HOT 5
- Unsupported Block Editor: Editor doesn't load on some Atomic sites on Android HOT 2
- TypeError: Cannot read property 'label' of undefined HOT 2
- TypeError: Cannot read property 'trim' of undefined HOT 3
- TypeError: Cannot read property 'name' of null HOT 3
- TypeError: Cannot read property 'scrollToEnd' of null HOT 1
- TypeError: Cannot set property 'block' of undefined HOT 1
- 'RNTAztecView/RNTAztecView.h' file not found HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gutenberg-mobile.