Giter Site home page Giter Site logo

Comments (5)

koke avatar koke commented on May 24, 2024 1

From my limited knowledge, I think the right approach to this is to leverage shouldComponentUpdate to decide when we need to re-render.

I see some of that logic already in withSelect and @wordpress/element so we might even get that for free in the future, but I'm still a bit lost on that part.

from gutenberg-mobile.

diegoreymendez avatar diegoreymendez commented on May 24, 2024 1

The update issue is not specific to RN though, although I can imagine it'd be more apparent. I can't remember right now if we made improvements for this in WPiOS, but we had already spotted the need to avoid updating the post state and saving on each keystroke.

That said, I'm not too sure if the one to define the logic for saving should be the editor or the consuming app.

from gutenberg-mobile.

SergioEstevao avatar SergioEstevao commented on May 24, 2024 1

@mchowning this looks related to: #1941

from gutenberg-mobile.

hypest avatar hypest commented on May 24, 2024

Another aspect to add is: who owns the undo history and what "chunks" of change are saved as a single undo record?

Currently, Aztec owns its editing history, including of course raw text modifications (versus, for example, styling changes). I think we will probably need to implement something clever there to efficiently store content changes in the RN/app state.

In that sense, I can't tell yet exactly when the Aztec instance should re-render or how often. I think I'd like to see some implementation of the undo/redo logic before forming an opinion.

from gutenberg-mobile.

hypest avatar hypest commented on May 24, 2024

The Aztec integration has changed quite a bit for some time now (with RichText component on the Gutenberg-web side) and this ticket is now hard to relate to any particular code part. The ticket was originally raised for visibility purposes so, closing now as out-of-date.

from gutenberg-mobile.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.