Comments (7)
Excellent point. At what point should it be dropped? Perhaps a better solution is to have a try/catch and if a 2006 comes up to recreate the connection
from dejavu.
I have a context manager for this somewhere, it caches connections and knows when to reconnect. It should also be able to clean-up a lot of the try: except:
clauses that are around a lot of the MySQL interactions.
I'll be working on a pull request if that is okay.
from dejavu.
Sounds great.
from dejavu.
After some more playing around, a friend and myself ended up editing dejavu quite heavily over the past 2 days. You can look at the changes in my fork (here).
I would love to merge them back into the main repository but the changes are quite big (basically a rewrite exempting the algorithm). It's up to you to decide if you want to accept the changes. Feel free to ask any questions as well!
from dejavu.
Actually the changes look great. A lot of things I haven't had time to do. Perhaps you also want to rewrite the go.py
to show off some of the new things - different recognizers, new syntax etc. Then make a pull request and I can take a closer look at all changes.
The biggest thing I don't see (but may have missed) was making sure the 'autocommit' was turned off by default, otherwise inserting hashes into mysql is much, much slower.
Also is the Queue in the cursor module to allow for processes to share?
from dejavu.
I've updated go.py
to contain some examples of usage now.
The Queue is for sharing and caching of connections across threads, each process will have its own Queue.
I would like to emphasize that the fork isn't perfect, and it still has some rough edges. Especially error handling has to be looked at (and documented).
from dejavu.
Looks great. Only thing is I'm a bit worried we'll blow away pgurdi's latest stuff which only fingerprints first n seconds of files and lets you conditionally keep/delete converted mp3 to wav files. But if you PR I can add that to your fork, or if you are inspired you can.
Re: error handling, any particular try/catches you are referring to?
from dejavu.
Related Issues (20)
- Failed to solve HOT 1
- Comparing short audio files
- Python Docker image bloated
- A directory of potentially duplicate audio files?
- it works well with python3.6 ~
- Not working for recordings
- Some errors when I use python3.7
- multiple concurrency
- Fingerprinting Audio With Differing Sample Rates HOT 1
- Jscght
- figerprinting file HOT 1
- Any way to generate the result image of the plots? HOT 1
- Does this package supports Python 3 HOT 4
- does this project work well on recognizing human speak? HOT 5
- Problem running the sample project HOT 1
- erors using fingerprint_file HOT 1
- Audio file
- Recognize TV shows using an HLS playlist HOT 6
- psycopg2.OperationalError
- Implementing Dejavu System with Individual Fingerprint Tables for Audio Files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dejavu.