Comments (4)
I'm working on fixing weapon skills. It'll be overhauled completely.
from sod.
@kayla-glick We dont do Weapon Skill with Reg-ex because its much more involved. We do it with NewItemEffects in the common/sod code. You can find examples in there I think in the melee_items.go
from sod.
Aah ok so it's done on an item-by-item basis then?
from sod.
Started to implement this for Bonk-Maestro's Handguards and Power-Assisted Lifting Belt but realized the current ApplyWeaponSpecialization
ref is not handling the difference between one hand and two hand. This is fine for the racials (because they cover both 1h and 2h), and fine for the dagger skill on the gnomer set (because there is no 2h daggers) but not usable for the two new items.
// Bonk-Maestro's Handguards
core.NewItemEffect(213278, func(agent core.Agent) {
character := agent.GetCharacter()
character.ApplyWeaponSpecialization(3, proto.WeaponType_WeaponTypeFist)
character.ApplyWeaponSpecialization(3, proto.WeaponType_WeaponTypeMace)
})
// Power-Assisted Lifting Belt
core.NewItemEffect(215380, func(agent core.Agent) {
character := agent.GetCharacter()
character.ApplyWeaponSpecialization(3, proto.WeaponType_WeaponTypeAxe)
character.ApplyWeaponSpecialization(3, proto.WeaponType_WeaponTypeSword)
character.ApplyWeaponSpecialization(3, proto.WeaponType_WeaponTypeMace)
})
from sod.
Related Issues (20)
- Mage Combustion + Fire Blast interaction with Overheat Rune HOT 1
- Invocation - Warlock SoD
- motw cant be turned off HOT 1
- Toughness armor talent doesn't calculate extra armor HOT 1
- Crash Report 540584983 HOT 1
- Crash Report -320155265 HOT 1
- Crash Report 516266071 HOT 1
- Crash Report 409573410 HOT 1
- Crash Report -1999082898 HOT 1
- Crash Report -40278359 HOT 1
- Melee hunter 2pc & 6pc set bonuses not working
- Druid Swipe hitting N-1 targets
- Missing items: Rage of Mugamba HOT 3
- Protection Paladin Implementation
- Shield Block Value Multiplier only applies to SBV gained through flat bonuses
- Phase 5: General Item Sets
- Phase 5: Weapon Effects HOT 1
- Phase 5: Trinkets
- (SoD Rogue) Crit chance of Mutilate and Envenom is incorrect HOT 1
- Crash Report -489862906 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sod.