Giter Site home page Giter Site logo

Comments (5)

rachelbaker avatar rachelbaker commented on July 21, 2024

@rmccue is there anything still to address here now that #154 was merged?

from wp-api.

rmccue avatar rmccue commented on July 21, 2024

@rmccue is there anything still to address here now that #154 was merged?

When we start on core integration, I'd like to consider this possibility then. Not something we can do before then really though. :)

from wp-api.

danielbachhuber avatar danielbachhuber commented on July 21, 2024

@rmccue I don't think this is still applicable?

from wp-api.

rmccue avatar rmccue commented on July 21, 2024

I think our is_error and as_error methods on the response object handle this pretty well now. Someday down the line, it'd be nice for is_wp_error to recognise ( $e instanceof WP_REST_Response ) && $e->is_error, but no need to keep this in the meantime I think.

from wp-api.

danielbachhuber avatar danielbachhuber commented on July 21, 2024

I agree.

from wp-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.