Giter Site home page Giter Site logo

Comments (7)

claudiosanches avatar claudiosanches commented on May 13, 2024

I really enjoyed the idea.
We can also take advantage and use filters and actions to facilitate this.

from wp-bootstrap-navwalker.

pattonwebz avatar pattonwebz commented on May 13, 2024

Sounds like an awesome idea, man. So is there any progress with it yet? I'm itching to get a glance at the code to see the direction your taking with this.

Also what kind of other features have been requested?

I'm totally up for helping out any way I can - even if it's just testing till I can break it haha! - but I'd love to get more involved in the development process as this grows.

from wp-bootstrap-navwalker.

mindctrl avatar mindctrl commented on May 13, 2024

I like where you're going with this. The modular idea is interesting. How do you see the walker callback working in wp_nav_menu to let it know which kind of nav you want for that location? Something like 'walker' => 'wp_bootstrap_navwalker::nav-list'?

The beauty of taking the time to also create a plugin is this will also give us utility classes needed to easily add the framework options to our themes as well.

I didn't quite understand what you mean here.

Understanding that some add-ons may require additional .less & .js files I think it is important to compile and minify all of out resources into single .css & .js files.

That's a good idea, but I wonder if it would conflict with other solutions that do this. Dependency Minification is a cool plugin I recently came across. Other caching solutions concat and minify too.

from wp-bootstrap-navwalker.

PlanBrewski avatar PlanBrewski commented on May 13, 2024

I'm glad you all like the idea.

@claudiosmweb I'm glad you like the idea, and that was the route I was hoping to go.

@pattonwebz No progress yet, just planning at this point. I hope to start sometime this week. As for features theres nothing really on my radar right now except for multilevel, but I think this might be a great way to implement the button walker I was talking about a while back, a new way of doing glyphicons, and possibly implementing my list nav walker as well.

@mindctrl That is a great question. Your suggestion may be the solution, but after giving it some thought I think it may be best to handle feature assignment form the class and define the nemu and its features via a function the hooks into the class.

Something like this maybe as there may be multiple add-ons you want to load witho with one menu. (just brainstorming)

if ( class_exists( 'WP_Bootstrap_Navwalker' ) ) {

    function wp_bootstrap_navwalker_setup() {

        add_wp_bootstrap_menu( 'primary', array( 
            'glyphcions',
            'nav-list' )
        );

        add_wp_bootstrap_menu( 'footer', array( 
            'glyphcions' )
        );
    }

    add_action( 'wp_bootstrap_navwalker_init', 'wp_bootstrap_navwalker_setup' );
}

This way every instance of the walker can support its own list of add-ons.

from wp-bootstrap-navwalker.

stinaq avatar stinaq commented on May 13, 2024

Hi! Really love this script! But do you have any idea when it might be ready for 3.0?

from wp-bootstrap-navwalker.

pattonwebz avatar pattonwebz commented on May 13, 2024

Hey @stinaq,

Ed actually made this 3.0 compatible pretty much as soon as Bootstrap 3 was out.

If your using 3.0 your good to go by following the instructions at the walker's main page :)

from wp-bootstrap-navwalker.

PlanBrewski avatar PlanBrewski commented on May 13, 2024

Thanks for the feedback everyone. As I am in the middle of a huge project at the moment I am going to close this issue and revisit it when I have more time.

from wp-bootstrap-navwalker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.