Comments (5)
👍 To wp media diff
Couple of questions:
- Does it need to implement a
wp media diff delete
too, or could we keep yourwp media diff display
aswp media diff
? For a delete function, I'd think you could pass image paths torm
. - Does it make sense to handle the use case in wp-cli/ideas#32 with this too?
from media-command.
On the first point it was useful for our own purposes here (it was the point of the work originally); there are checks in place in place to stop accidental behavior and unless you use the --hard option it'll put the files to the trash folder we're creating for soft deletes and inspection. On balance I think a user of the command is more (or just) as likely overall to make an irreparable mistake to their system as a result of passing output from it to rm than by using the tool directly, but happy to hear further views on that and make changes if people would rather delete wasn't there generally.
On the second point yes I think we can mod it to do wp-cli/ideas#32 as part of this. Just so I'm clear though, the intention of that is to find missing attachment sizes, so, for example, a selective thumbnail regeneration could take place? Or have I got the wrong end of the stick there?
from media-command.
On balance I think a user of the command is more (or just) as likely overall to make an irreparable mistake to their system as a result of passing output from it to rm than by using the tool directly, but happy to hear further views on that and make changes if people would rather delete wasn't there generally.
Rather than having a dedicated command for it, we could have an example in the ## EXAMPLES
section that shows you how to safely delete files by first moving them to the trash.
One opinion of WP-CLI is Composability is always a good idea, which also means:
A corollary of this is that commands should be orthogonal, which means that there should be no overlapping functionality between commands.
The user would be more empowered to know how to use rm
correctly.
Just so I'm clear though, the intention of that is to find missing attachment sizes, so, for example, a selective thumbnail regeneration could take place?
Correct: identify attachments missing specific image sizes, so you know whether you need to generate those image sizes.
from media-command.
@ChrisDean Still interested in submitting this?
from media-command.
Closing in favor of wp-cli/ideas#72
from media-command.
Related Issues (20)
- media regenerate not working HOT 1
- Can't regenerate a custom size HOT 1
- Import into specific directory/location HOT 2
- Is it possible to generate "XXX-scaled.jpg"? HOT 1
- intermediate_image_sizes_advanced filter not passing 3 arguments (fatal error) HOT 1
- Regenerate webp format
- WP-CLI Running In Docker Container Unable to Bulk Import Media HOT 2
- Skip Duplicates HOT 1
- time limit exceeded `Operation canceled' @ fatal/cache.c/GetImagePixelCache/1868. HOT 4
- How does delete works? HOT 1
- Typo in description for --caption parameter
- Can't regenerate images listed in wp media image-size HOT 1
- Segmentation fault when regenerating images for specific image type, stops regeneration HOT 1
- Update tests for new behavior when unexpected 'thumbnail' image size when original image is 150x150
- Found 1 image to regenerate. Warning: Can't find "DSC_XXXX" (ID XXXX). HOT 1
- Option to override filename while importing media HOT 3
- Dead code in media command class HOT 1
- A question about using "wp media import" command. HOT 2
- No thumbnail when importing PDF file using `media import` HOT 3
- Regenerating a single image size (re-)generates auto-scaled big images & auto-rotated images HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from media-command.