Comments (1)
Based on https://stackoverflow.com/questions/66122388/is-it-possible-to-walk-stack-frames-from-an-exception and looking through the StackWalker
docs, I'm not sure the complete issue would be feasible. (We can do some parts of it but not all of it)
- Most of our usages of
getStackTrace()
are from reporting the stack trace of an already thrown exception. However, the StackOverflow post linked above indicates thatStackWalker
can't be used to process the stack trace of an already thrown exception, soDriverStation.reportError()
andMathSharedStore.reportError()
have to keep theStackTraceElement[]
parameter for that use case. We could makeDriverStation.reportError(String error, boolean printTrace)
overload useStackWalker
, but that would lead to code duplication since we still need the logic for theStackTraceElement[]
case. - This isn't the main point of this issue, but the efficiency seems to be from not having to create all of the stack trace elements, but because our usages of the stack traces are reporting errors, we have to process all of the stack trace elements anyways. (The only elements we skip are from the top of the stack, which means that the walker still has to create all of the elements for us to either determine we should skip or to report in the (processed) stack trace)
Summary: We could use StackWalker
for DriverStation.reportError(String error, boolean printTrace)
, but that would lead to code duplication. If we want to use the stream API for more ergonomic processing, we could stream the array of stack trace elements (though that would add the stream API's overhead).
from allwpilib.
Related Issues (20)
- Epilogue warning in RapidReactCommandBot example
- LoggerTest.addMessageTest often fails due to race conditions
- RoboRIO team number setter: display/output log
- Memory Leek When Robot Container Object is Deconstructed HOT 7
- I Would Like to Volunteer HOT 1
- Add Catch2 to upstream_utils
- Add Upload Support for Persistent Tables HOT 1
- Generated command HID classes not included in C++ build, despite being included in the build.gradle HOT 1
- Change native builds from Gradle to cmake (tracking issue) HOT 7
- Replace MathUtil.clamp() with Java 21 Math.clamp() HOT 2
- [wpilibc] Check for invalid handles in destructors HOT 6
- PS4ControllerSim::SetTouchpad is in the header but didn't end up in a C++ file. HOT 2
- Prefer usage of QuickBuffers over Jackson for deserializing JSON HOT 1
- Simulation "Reset" removes all items under NetworkTables HOT 1
- Add Zone2d utility classes for defining field-based triggers and other use-cases HOT 1
- Sysid Limits HOT 1
- JDTLS errors when project is opened in non-VSCode editor HOT 1
- XRPGyro is missing getRotation2d
- Make wpi::MemoryBuffer::GetFile() use wpi::expected HOT 3
- [epilogue] Log internal debug data to the configured logger instead of networktables
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from allwpilib.