Is there some problem with the insertListener function?

[wqking]

Is there some problem with the insertListener function?

[wqking]

What problem?

[zhllxt]

`#include
#include "eventpp/eventdispatcher.h"
#include "eventpp/mixins/mixinfilter.h"

int main()
{
eventpp::EventDispatcher<int, void ()> dispatcher;

dispatcher.appendListener(3, []()
{
	std::cout << "Got event 31." << std::endl;
});

auto listener = dispatcher.appendListener(3, []()
{
	std::cout << "Got event 32." << std::endl;
});

dispatcher.insertListener(5, []()
{
	std::cout << "Got event 5." << std::endl;
}, listener);

dispatcher.dispatch(3);

// -- the output is :
// Got event 31.
// Got event 5.
// Got event 32.

while (std::getchar() != '\n');

return 0;

}
`

[wqking]

Thanks, I will look into it.

[wqking]

This is not a bug (at least not a serious bug) but needs improvement.
Function insertListener should check and forbid to insert a listener for different event with the one in before handle.
Also seems there should be more unit tests for insertListener.
I will fix this issue.

Currently before the fix, you just need to avoid to insertListener with different event.

[wqking]

I added function ownsHandle to check if the handle belongs the CallbackList or EventDispatcher.
You should call ownsHandle before insertListener if you are not sure if before belongs to the dispatcher.
insertListener doesn't verify the handle for performance reason.

So your sample code will look like,

if(dispatcher.ownsHandle(5, listener)) {
    dispatcher.insertListener(5, []()
    {
        std::cout << "Got event 5." << std::endl;
    }, listener);
}

[zhllxt]

Thanks, Nice work.