`have_enqueued_job` clashes with `rspec-rails` `3.4.0`

[wspurgin]

`have_enqueued_job` clashes with `rspec-rails` `3.4.0`

[aprescott]

Think I got one, actually:

# Temporarily work around a clash between rspec-rails 3.4.0 and
# rspec-sidekiq because of new ActiveJob matchers.
#
# See philostler/rspec-sidekiq#83
module RSpec
  module Sidekiq
    module Matchers
      def have_enqueued_sidekiq_job(*expected_arguments)
        HaveEnqueuedSidekiqJob.new expected_arguments
      end

      HaveEnqueuedSidekiqJob = HaveEnqueuedJob
    end
  end
end

[bkoltai]

+1 for PR!

[mhenrixon]

👍

[aprescott]

I see @mrbrdo issued #84 for this fix. Until that gets reviewed, merged and included in a release, is there a temporary work-around I can use to unblock gem updates?

[mrbrdo]

Or just use my branch in your gemfile.

[aprescott]

Git refs in a Gemfile lead to bulky vendor/cache directories, so I try to avoid them.

[fabn]

@philostler any ETA for this? I'd like to upgrade RSpec but this issue prevent me to do that.

[philostler]

Been busy with work etc recently, will review all PRs and Issues very soon.

[nickcoyne]

Was the PR not merged?

[philostler]

This should be fixed with #95 now