Giter Site home page Giter Site logo

Comments (3)

wtbarnes avatar wtbarnes commented on August 24, 2024

That is a good question...I think I created these properties in order to use them in the ionization cross-section calculation here:

if self.hydrogenic or self.helium_like:
and here:
B = 1 if self.hydrogenic else 2
. I was following the logic both from the Fontes cross-section paper as well as what is in the ioniz_cross.pro routine: https://sohoftp.nascom.nasa.gov/solarsoft/packages/chianti/idl/ionrec/ioniz_cross.pro

The conditions on $Z$ are likely just specific to that calculation so that condition should be dropped from these properties. I'm actually still a bit confused by the $Z\ge6$ condition. In the Fontes cross-section paper, it explicitly states that these cross-section calculations are for $10\le Z\le 92$ so the $Z\ge10$ condition makes sense, but I don't understand the $Z\ge6$ condition.

from fiasco.

jwreep avatar jwreep commented on August 24, 2024

Perhaps it would be worth dropping this in the definitions, and putting the requirements on atomic number into the cross-section calculation directly? I could handle that, if so.

from fiasco.

wtbarnes avatar wtbarnes commented on August 24, 2024

Yes, that's definitely the right move. Thanks for spotting this.

As a side note, I spoke with Peter Young about this issue of the range of Z for the cross-section calculation. He pointed out that in the Dere et al. 2007 (http://adsabs.harvard.edu/abs/2007A%26A...466..771D) paper, there's a note about the Fontes cross-sections being used for H-like ions of Carbon and above and using the FAC or BT scaling calculations for others. We should probably add a comment somewhere in that function that summarizes the justification in that paper.

from fiasco.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.