Comments (3)
You're right that this should be configurable. I think, a good place could be the Application object:
We could add a properly like "environment" or "deployment" that defaults to the currently checked out branch, if not set. Otherwise, it could be overwritten via string. But I'm not yet 100% sure. Need to discuss within the team. What's your opinion on this?
from wundergraph.
Yeah, adding it to the ApplicationConfig that is used to construct the Application feels like a natural place for it.
I think defaulting to branch may make deployment a bit tricky, as it affects the url.
I'd feel more comfortable with default to 'main' as it is, but can be overwritten by the applicationconfig.
It may make sense for the go server+hook server to consider an environment variable as well.
from wundergraph.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from wundergraph.
Related Issues (20)
- [Issue]: Not being able to send an array of strings for operations that requires them as query params HOT 2
- [Issue]: WG not sending query params when `statusCodeUnions` is `true` HOT 1
- 'SWRConfig' is not exported from '@wundergraph/swr' HOT 2
- [Issue]: mock server not working as expected HOT 2
- [Issue]: With openApiV2, BigInt cannot be serialized HOT 1
- [Issue]: Missing import sdk/server/fetch.ts HOT 4
- [Issue]: Scalar input fields on GraphQL datasource converted to strings HOT 12
- [Issue]: Live queries are not working when running server in debug mode (SvelteKit) HOT 2
- [Issue]: InputValidationError returns text/plain but should return application/json HOT 4
- [Issue]: Nextjs token based auth is not secure HOT 5
- Support for @tanstack/react-query v5 HOT 2
- Generated graphql Operations ignore the default values set in OAS Schema definition
- [Issue]: TestServer start timeout artificially limited to maximum of 60s HOT 1
- Object literal may only specify known properties, and 'type' does not exist in type 'JSONSchema7' HOT 5
- [Issue]: Nextjs App Router Migration Problem HOT 5
- introspect.graphql does not work for Contetnful GQL Schema HOT 3
- [Issue]: NextJS 14 failing to run useQuery calls that are Live Queries HOT 5
- Remove dependency on terminate package HOT 1
- [Issue]: Unable to get headers in revalidate hook HOT 1
- [Issue]: Crash in Subscriptions after publishing an event to NATS. HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wundergraph.