Giter Site home page Giter Site logo

Comments (4)

aa22dev avatar aa22dev commented on July 19, 2024 1

Unless I'm missing something, that has been a known issue since a long time, and exists because of the way iFastNet coded the domain search in the panel. In fact, it is the sole reason https://github.com/WybeNetwork/VistaPanel-Customizations/tree/master/responsive-domain-search exists, as it was created to address this problem and has successfully done so.
I tested the Dark theme with responsive-domain-search and it worked perfectly.

Yes you are actually right but If I'll find a time, then I'll fix the responsiveness issue of domain search bar directly using CSS.

I am uncertain if we should patch the other themes to include this fix, however, considering Responsive Domain Search does that job well. In any case, we can discuss this.

Actually, If this fix is directly implemented in CSS then an extra HTTP request can be avoided.

I am unable to replicate this. Can you show an example?

I'm attaching the screenshot
image

In this screen you can see that the stats table wanted to maintain it's size instead because of the long text, if we want to fix this issue then only one line of CSS code should be added to the file, which I might add soon.

Sorry for the mistake, I mean't account details table instead of Stats table.

from vistapanel-themes.

4yx avatar 4yx commented on July 19, 2024

Domain Checker search bar not responsive (size is fixed)

Unless I'm missing something, that has been a known issue since a long time, and exists because of the way iFastNet coded the domain search in the panel. In fact, it is the sole reason https://github.com/WybeNetwork/VistaPanel-Customizations/tree/master/responsive-domain-search exists, as it was created to address this problem and has successfully done so.
I tested the Dark theme with responsive-domain-search and it worked perfectly.

To my knowledge, the only person that attempted to fix the responsiveness issues directly in the themes was either einet or you, in 23e36a5, in the lite themes and the themes based on them, so any theme that doesn't fit that criteria should have the same issue.

I am uncertain if we should patch the other themes to include this fix, however, considering Responsive Domain Search does that job well. In any case, we can discuss this.

Stats table size causes responsiveness issue

I am unable to replicate this. Can you show an example?
I know the stats are broken in some themes, i.e Retro which I was working on (and can't remember where 😂), but Dark doesn't seem to have this issue.

from vistapanel-themes.

4yx avatar 4yx commented on July 19, 2024

If I'll find a time, then I'll fix the responsiveness issue of domain search bar directly using CSS.

Alright, I won't protest this, if possible just make sure that it won't break Responsive Domain Search :D

if we want to fix this issue then only one line of CSS code should be added to the file, which I might add soon.

Nice!

from vistapanel-themes.

aa22dev avatar aa22dev commented on July 19, 2024

Closing as fixed in #26

from vistapanel-themes.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.