compiled binary does not work well

[x-motemen]

compiled binary does not work well

[syohex]

Some package like os/user cannot be cross-compiled. Released packages of ghq are
cross-compiled on Linux 64bit, so cross-compiled binaries of Windows and MacOSX does
not work. Such packages should be removed and rewrite if author releases binaries for
various platforms.

See

• peco/peco#102
• http://dominik.honnef.co/posts/2013/12/cross_compiling_go_and_hidden_uses_of_cgo/

[motemen]

Thank you, I will consult it shortly.

[syohex]

FYI. https://github.com/mitchellh/go-homedir

diff --git a/local_repository.go b/local_repository.go
index 59edc8d..a7c8fab 100644
--- a/local_repository.go
+++ b/local_repository.go
@@ -4,12 +4,12 @@ import (
    "fmt"
    "net/url"
    "os"
-   "os/user"
    "path"
    "path/filepath"
    "strings"

    "github.com/motemen/ghq/utils"
+        "github.com/mitchellh/go-homedir"
 )

 type LocalRepository struct {
@@ -170,10 +170,10 @@ func localRepositoryRoots() []string {
    utils.PanicIf(err)

    if len(_localRepositoryRoots) == 0 {
-       usr, err := user.Current()
+       homedir, err := homedir.Dir()
        utils.PanicIf(err)

-       _localRepositoryRoots = []string{filepath.Join(usr.HomeDir, ".ghq")}
+       _localRepositoryRoots = []string{filepath.Join(homedir, ".ghq")}
    }

    for i, v := range _localRepositoryRoots {

[motemen]

Cool

[shrkw]

Awesome! 👏