Giter Site home page Giter Site logo

Comments (11)

just5ky avatar just5ky commented on May 22, 2024 2

i will still keep my repo up-to-date.
If anyone wanna use my version, they can
i will only push latest & dev , every time you update your code, I just have to pull and merge in my repo, rest everything will be done automatically
@xavier-hernandez

from goaccess-for-nginxproxymanager.

just5ky avatar just5ky commented on May 22, 2024 1

@xavier-hernandez i tested both Latest and Dev image, works just fine.

from goaccess-for-nginxproxymanager.

xavier-hernandez avatar xavier-hernandez commented on May 22, 2024 1

@martadinata666 Appreciate the input. I think you are 100% right on the personal preference point. I think right now this is what I feel the most comfortable with. At some point :latest will equal :vXXX and I might actually take out caching altogether.

from goaccess-for-nginxproxymanager.

xavier-hernandez avatar xavier-hernandez commented on May 22, 2024

@just5ky I was actually looking at github actions recently but didn't really have time. I was looking at something created by crazy-max but yours looks super easier. Feel free to create a PR. Once you complete your PR I'll try it out on a different repo of mine and make sure everything works then I'll approve it. Don't want to accidentally mess up the images :P

What does this do, schedule an auto build?
schedule:
- cron: '50 15 * * *'

from goaccess-for-nginxproxymanager.

just5ky avatar just5ky commented on May 22, 2024
on:
  schedule:
    - cron: '50 15 * * *'      #Build image when dailt at 15:50 but im not sure which timezone.
  push:
    branches: [ main ]        #Build image when there is a comitt push
    # Publish semver tags as releases.
    tags: [ 'v*.*.*' ]
  pull_request:
    branches: [ main ]       #Build image after a pull request is accepted
  workflow_dispatch:       #Adds a button to manually build image in GitHub actions page.

You can use https://crontab.guru/ to make a cron schedule

I am still playing around with it, but it works

from goaccess-for-nginxproxymanager.

just5ky avatar just5ky commented on May 22, 2024

I also found this
https://github.com/Yooooomi/your_spotify/blob/master/.github/workflows/client.yml

Its clear implementation, but it does not have automatic builds

from goaccess-for-nginxproxymanager.

just5ky avatar just5ky commented on May 22, 2024

You can just add this to your test repo like test_repo/.github/workflows/FILENAME.yml

you need to create a GitHub secret for your docker hub access token with the name DOCKERHUB_TOKEN

name: Docker multi-arch build and push

on:
  schedule:
    - cron: '50 15 * * *'
  push:
    branches: [ main ]
    tags: [ 'v*.*.*' ]
  pull_request:
    branches: [ main ]
  workflow_dispatch:

env:
  REGISTRY: docker.io
  IMAGE_NAME: test_image_name

jobs:
  build:

    runs-on: ubuntu-latest
    permissions:
      contents: read
      packages: write
      # This is used to complete the identity challenge
      # with sigstore/fulcio when running outside of PRs.
      id-token: write

    steps:
      - name: Checkout repository
        uses: actions/checkout@v2

      # https://github.com/docker/setup-qemu-action
      - name: Set up QEMU
        uses: docker/setup-qemu-action@v1

      - name: Setup Docker buildx
        uses: docker/setup-buildx-action@79abd3f86f79a9d68a23c75a09a9a85889262adf

      - name: Login to Docker Hub
        uses: docker/login-action@v1
        with:
          username: ${{ secrets.DOCKERHUB_USERNAME }}
          password: ${{ secrets.DOCKERHUB_TOKEN }}
        
      - name: Build the Docker image
        run: docker buildx build --push --platform linux/amd64,linux/arm/v6,linux/arm/v7,linux/arm64/v8  --tag ${{ secrets.DOCKERHUB_USERNAME }}/test_image_name .

from goaccess-for-nginxproxymanager.

xavier-hernandez avatar xavier-hernandez commented on May 22, 2024

@just5ky @martadinata666

@just5ky I committed your PR then I made some modifications that I was talking about previously. I also added some additional steps. Not sure if everything is as simple as it should be but have a look at the workflow. Can you test the new develop image and latest image on your local, before I update the README file?

  • changed the auto-build for tags only
  • will run the workflow manually for main and develop branch, until I get a better handle on mods that I make
  • main branch - docker image will be flagged as "latest"
  • tags - docker image will be flagged with the tag, i.e. "v1.0.5"
  • develop branch - docker image will be flagged as "develop"

from goaccess-for-nginxproxymanager.

xavier-hernandez avatar xavier-hernandez commented on May 22, 2024

@just5ky @martadinata666 - thanks for all your help on getting this done. Saved me a bunch of time.

from goaccess-for-nginxproxymanager.

martadinata666 avatar martadinata666 commented on May 22, 2024

@just5ky @martadinata666

@just5ky I committed your PR then I made some modifications that I was talking about previously. I also added some additional steps. Not sure if everything is as simple as it should be but have a look at the workflow. Can you test the new develop image and latest image on your local, before I update the README file?

* changed the auto-build for tags only

* will run the workflow manually for main and develop branch, until I get a better handle on mods that I make

* main branch - docker image will be flagged as "latest"

* tags - docker image will be flagged with the tag, i.e. "v1.0.5"

* develop branch - docker image will be flagged as "develop"

As workflows itself depends on personal preferences, from your need stated the current workflow is sufficient.

  • main branch - docker image will be flagged as "latest"
  • tags - docker image will be flagged with the tag, i.e. "v1.0.5"

That mean there is 3 flavour instead of two, as i stated before in PR, usually :latest is same as the :vXXX , and keep follow the same with the most recent tag. But your flow :latest main branch, :vXXX tagged version, :develop is develop branch, and keep watching the cache you may still stuck on old version package.

from goaccess-for-nginxproxymanager.

xavier-hernandez avatar xavier-hernandez commented on May 22, 2024

@just5ky tomorrow I'll update the readme file that the 3 docker image versions are available in my repo. Did you want me to remove the link to yours or will you continue to update your docker images?

from goaccess-for-nginxproxymanager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.