iPXE 1.0.0 build always

[sebaxakerhtc]

iPXE 1.0.0 build always

[NiKiZe]

iPXE version comes from git tags, but if I remember correctly git is not available to the build process itself. And in that case the generic 1.0.0+ version is shown even if it is the latest code.

[xbgmsharp]

iPXE does not manage version, it is always the generic 1.0.0+ version. There are very few tags over the +10 years.
The important part is the git commit in the versioning as per https://ipxe.org/cfg/version and
https://dox.ipxe.org/version_8c.html#a36f8da1d7cefa8b6bf0fd6509cd0162a

You might be able to change it:
https://github.com/ipxe/ipxe/blob/5aee6b81d73086fd4a48f2280043d7b5518b3303/src/Makefile#L210

[NiKiZe]

From the build perspective git might be a risk. So not available at build, and thus closed as "works as intended, won't fix" the issue is there but nothing that is reasonable to do anything about, or this is duplicate of other issue.

You always build master, it is good to see which version that is. But it is still the latest source, regardless of the version string ending up in the build.

[sebaxakerhtc]

in that case the generic 1.0.0+ version is shown even if it is the latest code

Hope it is

[xbgmsharp]

https://github.com/xbgmsharp/ipxe-buildweb/blob/master/install.sh#L38

[sebaxakerhtc]

https://github.com/xbgmsharp/ipxe-buildweb/blob/master/install.sh#L38

Thank you for the project!
I was inspired by your project and made a similar - ipxe-simple
Yes, i reviewed a whole code, but still can't find why the version of builded images 1.0.0+
It's better to show a real version isn't it?

[sebaxakerhtc]

iPXE does not manage version, it is always the generic 1.0.0+ version. There are very few tags over the +10 years.

Yes, it is. I understand, the code still latest, only cosmetic one is when you build it from source - it shows the 1.21.1+(tag) and revision, but from ipxe-buildweb is always 1.0.0+
Thats why people think is OLD.

[NiKiZe]

Again if you don't have git available and a full clone then the version is not correct.

Are you building with a full git checkout? And is the git command available and found by make?

If this works correctly you will currently get the 1.21.1+.... Version tag as in @sebaxakerhtc but something seems to make this fail in buildweb?

[sebaxakerhtc]

something seems to make this fail in buildweb?

Yes. It's a bug of ipxe-buildweb. I don't understand why issue is closed if the problem was not solved.
This project not work at all because of missing packages if you build it from source, but work if we just pull and run it.
But now the main question is why always build v1.0.0 and how can we make it to work normally.
There is a same question (as you know @NiKiZe) at the Github Discussions of ipxe.

Here is the part of code mentioned by the @xbgmsharp it this comment
Looks like we have a code, but this part does not work

VERSION_MAJOR	:= $(word 1,$(VERSION_TUPLE))
VERSION_MINOR	:= $(word 2,$(VERSION_TUPLE))
VERSION_PATCH	:= $(word 3,$(VERSION_TUPLE))

That's why used

else
VERSION_MAJOR	= 1
VERSION_MINOR	= 0
VERSION_PATCH	= 0
EXTRAVERSION	= +

May be it's time to change the code to see a real tag 1.21.1+ and the commit, like when we build it from source?

[sebaxakerhtc]

From the build perspective git might be a risk. So not available at build, and thus closed as "works as intended, won't fix" the issue is there but nothing that is reasonable to do anything about, or this is duplicate of other issue.

You always build master, it is good to see which version that is. But it is still the latest source, regardless of the version string ending up in the build.

Understand you. I will stop posting to this issue. Thank you!