Giter Site home page Giter Site logo

Comments (9)

xelalexv avatar xelalexv commented on June 8, 2024 1

I'm still on vacation, but could probably create a new release next week.

from dregsy.

xelalexv avatar xelalexv commented on June 8, 2024 1

released with 0.4.3 just now

from dregsy.

xelalexv avatar xelalexv commented on June 8, 2024

How about using regex: 14\.(1[5-9]|[2-9][0-9])\.[0-9]+-(alpine|buster) for the second expression? This should catch everything >= 14.15.x? Note the added + to catch multi-digit patch levels.

BTW, semver tag filters will (probably) not work with these kind of tags, since the lib used for this expects clean semver strings, and at most tolerates a v at the start. We may have to look into removing prefixes/suffixes such as architectures and platforms to improve on this.

I double checked and it turns out that the blang semver lib does accept suffixes as found in your use case, as long as the string starts with a full major.minor.patch semver. But still won't help in this particular case, so the suggested regex above still stands.

from dregsy.

xelalexv avatar xelalexv commented on June 8, 2024

An idea for improvement: If we introduce a tag filter prune:, which is a regex that gets applied last on the result of tag filtering, then your use case could be written like this:

tags:
- semver: >=12.19.x || >=14.15.x
- prune: .+-(alpine|buster)

from dregsy.

Junkern avatar Junkern commented on June 8, 2024

Oh, this looks really neat and looks exactly what I need.
One suggestion: Could it be named only insteead of prune? Makes it more explicit what is being done with that filter. On the first sight it reads like all images which apply to .+-(alpine|buster) are being removed from the result set.
Do you need help in reviewing the https://github.com/xelalexv/dregsy/compare/issue72 branch?

from dregsy.

xelalexv avatar xelalexv commented on June 8, 2024

I wasn't sure myself about prune, I agree that it may be a bit misleading. How about keep?

from dregsy.

Junkern avatar Junkern commented on June 8, 2024

keep also sounds like a really good option, even better than only

from dregsy.

xelalexv avatar xelalexv commented on June 8, 2024

implemented with PR #77

from dregsy.

Junkern avatar Junkern commented on June 8, 2024

Thanks a lot @xelalexv !
Is there an ETA on a new release?

from dregsy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.