xen-troops/libxenbe

libxenbe's Issues

Need to upgrade Catch

During the upgrade of yocto to kirkstone we met an issue in Catch. For now, it is workarounded by hard-coded constants.
But it's obvious that we need to solve it in the proper way - to upgrade the Catch test-framework.

Apply Xen Code style

In order to be upstreamed to community, xen coding style should be used.
Apply Xen code style. Described in xen/CODING_STYLE document.

prot is not respected while mapping grant references

libxenbe/src/XenGnttab.cpp

Line 88 in 6769e73

PROT_READ | PROT_WRITE);

Move log to standalone library

Xen BE log also is used in DisplayManager.
Move log to standalone lib to be used in different projects.

Reimplement frontend xenstore handling

There are some issues with frontend handling:

• on xl shutdown DomU we have:

10.07.17 16:07:12.849 | XenStore | DBG - Path triggered: /local/domain/0/backend/vdispl/72/0/state
10.07.17 16:07:12.849 | XenStore | DBG - Path triggered: /local/domain/0/backend/vdispl/72/0/online
10.07.17 16:07:12.849 | XenStore | DBG - Path triggered: /local/domain/0/backend/vdispl/72/0/online
10.07.17 16:07:12.849 | XenStore | DBG - Stop
10.07.17 16:07:12.850 | DisplFrontend | ERR - Dom(72/0) Resource deadlock avoided
10.07.17 16:07:12.850 | DisplFrontend | INF - Dom(72/0) Set backend state to: [Closing]
10.07.17 16:07:12.850 | XenStore | DBG - Write int /local/domain/0/backend/vdispl/72/0/state : 5
10.07.17 16:07:12.850 | XenStore | DBG - Write string /local/domain/0/backend/vdispl/72/0/state : 5
10.07.17 16:07:12.851 | XenStore | DBG - Path triggered: /local/domain/0/backend/vdispl/72/0/state
10.07.17 16:07:12.851 | XenStore | DBG - Path triggered: /local/domain/0/backend/vdispl/72/0/state
10.07.17 16:07:12.851 | DisplFrontend | DBG - On frontend closing : 72
10.07.17 16:07:12.851 | DisplFrontend | INF - Dom(72/0) Set backend state to: [Closed]
10.07.17 16:07:12.851 | XenStore | DBG - Write int /local/domain/0/backend/vdispl/72/0/state : 6
10.07.17 16:07:12.851 | XenStore | DBG - Write string /local/domain/0/backend/vdispl/72/0/state : 6
10.07.17 16:07:12.851 | XenStore | DBG - Path triggered: /local/domain/0/backend/vdispl/72/0/state

and there is zombie xen store entries:

/local/domain/0/backend/vdispl = ""
/local/domain/0/backend/vdispl/72 = ""
/local/domain/0/backend/vdispl/72/0 = ""
/local/domain/0/backend/vdispl/72/0/state = "6"
/local/domain/0/backend/vdispl/73 = ""
/local/domain/0/backend/vdispl/73/0 = ""
/local/domain/0/backend/vdispl/73/0/state = "6"

When starts backend again:

10.07.17 16:25:26.663 | ShellSurface | DBG - Config handler, edges: 0, width: 1280, height: 1024
10.07.17 16:25:26.663 | Display | DBG - Dispatch events: 5
10.07.17 16:25:26.663 | XenStore | DBG - Set watch: /local/domain/0/backend/vdispl
10.07.17 16:25:26.663 | XenStore | DBG - Path triggered: /local/domain/0/backend/vdispl
10.07.17 16:25:26.663 | InputManager | DBG - Create
10.07.17 16:25:26.663 | XenStore | DBG - Watch triggered: /local/domain/0/backend/vdispl
10.07.17 16:25:26.663 | DisplBackend | DBG - Frontend list changed
10.07.17 16:25:26.663 | XenStore | DBG - Create xen store
10.07.17 16:25:26.663 | VkbdBackend | DBG - Create backend, device: vkbd, dom Id: 0
10.07.17 16:25:26.663 | XenStore | DBG - Start
10.07.17 16:25:26.663 | XenStore | DBG - Set watch: /local/domain/0/backend/vkbd
10.07.17 16:25:26.663 | XenStore | DBG - Set watch: /local/domain/0/backend/vdispl/72
10.07.17 16:25:26.663 | XenStore | DBG - Set watch: /local/domain/0/backend/vdispl/73
10.07.17 16:25:26.663 | XenStore | DBG - Path triggered: /local/domain/0/backend/vkbd
10.07.17 16:25:26.663 | XenStore | DBG - Watch triggered: /local/domain/0/backend/vkbd
10.07.17 16:25:26.663 | VkbdBackend | DBG - Frontend list changed
10.07.17 16:25:26.663 | XenStore | DBG - Path triggered: /local/domain/0/backend/vdispl/72
10.07.17 16:25:26.664 | XenStore | DBG - Watch triggered: /local/domain/0/backend/vdispl/72
10.07.17 16:25:26.664 | DisplBackend | DBG - Device list changed
10.07.17 16:25:26.664 | DisplBackend | INF - Create new frontend: Dom(72/0)
10.07.17 16:25:26.664 | XenStore | DBG - Create xen store
10.07.17 16:25:26.664 | DisplFrontend | DBG - Dom(72/0) Create frontend handler
10.07.17 16:25:26.664 | DisplFrontend | DBG - Frontend path: /local/domain/72/device/vdispl/0
10.07.17 16:25:26.664 | DisplFrontend | DBG - Backend path: /local/domain/0/backend/vdispl/72/0
10.07.17 16:25:26.664 | XenStore | DBG - Stop
10.07.17 16:25:26.664 | XenStore | DBG - Delete xen store
10.07.17 16:25:26.664 | DisplBackend | ERR - Can't read from: /local/domain/72/name
10.07.17 16:25:26.664 | XenStore | DBG - Path triggered: /local/domain/0/backend/vdispl/73
10.07.17 16:25:26.664 | XenStore | DBG - Watch triggered: /local/domain/0/backend/vdispl/73
10.07.17 16:25:26.664 | DisplBackend | DBG - Device list changed
10.07.17 16:25:26.664 | DisplBackend | INF - Create new frontend: Dom(73/0)
10.07.17 16:25:26.664 | XenStore | DBG - Create xen store
10.07.17 16:25:26.664 | DisplFrontend | DBG - Dom(73/0) Create frontend handler
10.07.17 16:25:26.665 | DisplFrontend | DBG - Frontend path: /local/domain/73/device/vdispl/0
10.07.17 16:25:26.665 | DisplFrontend | DBG - Backend path: /local/domain/0/backend/vdispl/73/0
10.07.17 16:25:26.665 | XenStore | DBG - Stop
10.07.17 16:25:26.665 | XenStore | DBG - Delete xen store
10.07.17 16:25:26.665 | DisplBackend | ERR - Can't read from: /local/domain/73/name

Compilation fails with XEN 4.11

I'm getting error

src/XenGnttab.cpp:149:55: error: 'GNTDEV_DMA_FLAG_WC' was not declared in this scope

I think, #41 is a good workaround.

XenGnttabBuffer - make class final

Class does not have a virtual dtor, this is the reason why it is not possible to inherit it.
Add 'final' declaration to check the inheritance at compile time.