Calling 'stop()' sometimes leads to the client being 'disconnected'

[CamilleDrapier]

Calling 'stop()' sometimes leads to the client being 'disconnected'

[sonnyp]

Would be nice to have a way to reproduce.
Which server / version? What is the code that reproduce the problem ?

Anyhow - could you check if the following fixes the problem: #967

[sonnyp]

after explicitly calling the client close method

Did you mean the stop method?

[CamilleDrapier]

Thank you for your reply!

I do not think I can provide a way to reproduce, as this happens only sometimes with our quite complex setup that I cannot share publicly, sorry. I noticed this problem with the 0.13.1 client at least. I'm not sure about the server though!

Anyhow - could you check if the following fixes the problem: #967

Thanks! I think the changes looks nice, but I do not think it would solve the problem I described:

• I do not think it would prevent for a closing event to be handled before a disconnecting event.
• In the case that a closing get processed before a disconnecting, if would still end up in a diconnected state wouldn't it?

Of course, I'm not very proficient with the code base here, so I might have missed some side effect of your proposed changes that would solve the problem 🙇

Did you mean the stop method?

Yes, sorry for the confusion!