TestParse failure if /var/run/postgresql is missing

[xo]

TestParse failure if /var/run/postgresql is missing

[kenshaw]

I cannot reproduce this. I would need more information. Did you modify/change your local copy of the repository?

[dolmen]

No, I have not changed my local copy. go describe --always --dirty would have reported this (--dirty flag).

[kenshaw]

@dolmen I would need more information then. Are you running an old version of Go or some such? Please provide information on the platform / go version / etc. you're using. Otherwise, I have nothing available to me to reproduce this behavior.

[dolmen]

go version go1.10.3 darwin/amd64

[dolmen]

I've gone back in history to find where the breakage is starting (git checkout HEAD~1 && go test -run TestParse).

First commit where go test -run TestParse fails is c1aceeb.

[dolmen]

I notice that resolving Postgres URL calls os.Stat (in func mode in util.go).

I don't have Postgres installed on my machine, so /var/run/postgresql doesn't exist. This is the difference.

I'm updating the title. Please reopen.

[dolmen]

It is very bad that a function called Parse has different results depending on the filesystem state.

Worse: this behaviour is not documented.

[kenshaw]

@dolmen I appreciate your interest in this project, but this is not an actual issue. The unit tests work properly to test what they were designed to test. If you'd like to submit a PR selectively disabling these unit tests for use on environments where PostgreSQL is not installed, I'd consider merging that.

[dolmen]

Because of this issue, the testsuite doesn't work also on non-Unix environments (e.g. Windows).

[kenshaw]

@dolmen I've already stated that if you'd like to submit a PR selectively disabling this functionality (ie, for certain environments such as Windows), I'd be open to it. As it is, the reason this won't work on Windows, is because Windows (until very recently) has not supported Unix Domain Sockets. That said, the latest version of Windows 10 1603 does indeed support Unix Domain Sockets. As such, the correct thing to do here would be to:

1. First fix Go to work with AF_UNIX on Windows
2. Submit a PR changing the path this is used against, selectively based on OS using Go's build tags

Also, it's worth noting that unit tests do not need to work on every platform. These unit tests work for all the testing environments they were designed for. If they are not working on your platform, that's because you're using a non-standard platform (Windows) for development.

I have no intention of rewriting unit tests to work on broken Windows environments. By and large the users / developers of Go, usql, and dburl are not using Windows systems. If you would like the unit tests to work on (in my opinion) the broken Windows platform, feel free to submit a PR. I'll gladly accept it assuming it is well written.