Naming collision with multiple foreign keys referencing one table

[xo]

Naming collision with multiple foreign keys referencing one table

[kenshaw]

Yes, I see the issue. I'm working on a fix for this now. What will end up happening is that there will likely be 2 new command line options that toggle behavior for this, however I'm looking into seeing if there is a way to detect this automatically and force the behavior.

[kenshaw]

I've pushed a change that should fix this in the default case, and introduces a new command line option, --fk-mode that provides a number of different types of foreign key modes. The default, smart will look if there are other foreign keys with that same parent name and use the field foreign key mode, otherwise if there are no collisions, then the parent foreign key mode will be used.

A summary of the foreign key modes / behaviors:

smart  - default behavior; will use parent when no name collisions, and field when there are
parent - foreign key funcs on generated types as will be in the form of '<RefTable>'.
field  - foreign key funcs on generated types as will be in the form of '<RefTable>By<FieldName>'
key    - foreign key funcs on generated types as will be in the form of '<RefTable>By<KeyName>'

For example, if you have a simple authors and books relationship (as in the examples), then the following will be the result for the different modes:

parent - func (b *Book) Author()
field  - func (b *Book) AuthorByAuthorID()
key    - func (b *Book) AuthorByFk123() // (assuming the foreign key name is 'fk_123')

[kenshaw]

Let me know if that works for you.

I am hesitant to do anything more complicated or to change the templates, as I think if there is more custom logic/behavior necessary, then one likely needs to use custom templates for their schema as it is not possible to accommodate all the different schema designs styles, and also still work across the supported database types, here.

[nochso]

Thank you very much! The change works fine for me.

Just one minor thing: the default argument for --fk-mode shows as a pointer to FkMode.

  --fk-mode FK-MODE, -k FK-MODE
                         sets mode for naming foreign key funcs in generated Go code [values: <smart|parent|field|key>] [default: smart] [default: 0xc82000e978]

[kenshaw]

I'm aware of the issue -- it's a problem with the package I'm using for command line argument parsing, which is why I manually put the other [default: smart] text there.

Glad it works for you!