Giter Site home page Giter Site logo

Rename crate about endian_codec HOT 6 CLOSED

xoac avatar xoac commented on June 20, 2024 1
Rename crate

from endian_codec.

Comments (6)

Kixunil avatar Kixunil commented on June 20, 2024 1

How about binary_codec?

from endian_codec.

Kixunil avatar Kixunil commented on June 20, 2024 1

I definitely agree with not jumping on renaming too soon! I meant it more as a suggestion if the situation changes.

from endian_codec.

chrysn avatar chrysn commented on June 20, 2024

packed-endian-struct, maybe (given that the serialization it produces doesn't have padding AFAICT)?

from endian_codec.

xoac avatar xoac commented on June 20, 2024

I would propose endian_codec and I decide to use _ after reading this issue

This will also change SerializeLittleEndain trait to EncodeLEetc. because the name was to long in practical use.

from endian_codec.

wucke13 avatar wucke13 commented on June 20, 2024

Quite nice, that name! I suppose that both of you have a look of packed_struct. It looks like it is unmaintained, and the ergonomics are not super good (e.g. I wasn't able to get started in 20 minutes), however, feature wise it looks really complete & good.

from endian_codec.

xoac avatar xoac commented on June 20, 2024

Renaming create is still an option. But:

  • it has to be much better name (not just better)
  • crate has to be fully implemented

I think that the name is lacking of pack word so it could be pack_(with)_endian or struct_pack_endian, endian_packed packed_struct. I think pack should replace codec since it can pack and unpack objects what is a special case of codec.

I would at this moment vote against change the name. Why?:

  • the crate is not supper important
  • it's already published to crates.io
  • crate can be found by adding category and keywords
    at this moment there are still free slots (and endian can be removed - it's in name)
      keywords = ["no_std", "endian", "bytes"]
      categories = ["no-std", "parsing"]
    
  • This crate will be probably useful with no_std environment so I added it to awesome-emebedded-rust to be easier findable

I will not go with binary_codec - because can codec be done without binary?

I still think that endian is good part in name: Look at documentation:
image
just PackedSize don't contains endain in name. At it's just helping trait that I would be happy to hide from the end user.

from endian_codec.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.