Saucelabs failure does not make chimp exit non-zero

[joscha]

Saucelabs failure does not make chimp exit non-zero

[rsshilli]

I opened a PR anyway to hopefully get this resolved. #691

I don't remember what the bug is referring to. I don't maintain this package anymore. I approve this PR.

[rsshilli]

We use CircleCI / AWS Fargate and see this too. I don't think this has anything to do with SauceLabs.

[rsshilli]

This bug is super dangerous. I found out that one of our tests has been reporting as passing for months now but it's actually been broken the whole time. Yuck. The error I'm getting is:

  ✖ And I close the Risk Tables report tab
[chimp] Detected an unhandledRejection:
[chimp][hooks] Error: no such window: target window already closed
    from unknown error: web view not found
    at new RuntimeError (node_modules/webdriverio/build/lib/utils/ErrorHandler.js:144:12)
    at Request._callback (node_modules/webdriverio/build/lib/utils/RequestHandler.js:316:39)
    at Request.self.callback (node_modules/webdriverio/node_modules/request/request.js:186:22)
    at emitTwo (events.js:126:13)
    at Request.emit (events.js:214:7)
    at Request.<anonymous> (node_modules/webdriverio/node_modules/request/request.js:1163:10)
    at emitOne (events.js:116:13)
    at Request.emit (events.js:211:7)
    at IncomingMessage.<anonymous> (node_modules/webdriverio/node_modules/request/request.js:1085:12)
    at Object.onceWrapper (events.js:313:30)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1064:12)
    at node_modules/continuation-local-storage/node_modules/async-listener/glue.js:188:31
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickDomainCallback [as _tickCallback] (internal/process/next_tick.js:218:9)

@sanjo and @samhatoum I went to go submit a PR for this, and discovered that the correct code is in there:

https://github.com/xolvio/chimp/blame/6f3c6ea90405f9d3bcd2e4d8b6d321dbf0f09d10/src/lib/cucumberjs/hooks.js#L110-L111

Unfortunately it's commented out with a comment from 2 different commits from you from 2015 saying

Don't exit until the waitUntil uncaught promise bug is fixed in WebdriverIO

What bug is that? Is it this one?

webdriverio/webdriverio#1227

I can't understand why commenting out this exit call fixes that. Help?

[samhatoum]

This issue is being tracked in Chimpy
https://github.com/TheBrainFamily/chimpy/issues